Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Side by Side Diff: src/compiler/js-type-feedback.cc

Issue 1140943003: [turbofan] Reenable feedback for LoadNamed. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/flag-definitions.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/js-type-feedback.h" 5 #include "src/compiler/js-type-feedback.h"
6 6
7 #include "src/property-details.h" 7 #include "src/property-details.h"
8 8
9 #include "src/accessors.h" 9 #include "src/accessors.h"
10 #include "src/ast.h" 10 #include "src/ast.h"
(...skipping 258 matching lines...) Expand 10 before | Expand all | Expand 10 after
269 } 269 }
270 270
271 271
272 Reduction JSTypeFeedbackSpecializer::ReduceJSLoadProperty(Node* node) { 272 Reduction JSTypeFeedbackSpecializer::ReduceJSLoadProperty(Node* node) {
273 return NoChange(); 273 return NoChange();
274 } 274 }
275 275
276 276
277 Reduction JSTypeFeedbackSpecializer::ReduceJSStoreNamed(Node* node) { 277 Reduction JSTypeFeedbackSpecializer::ReduceJSStoreNamed(Node* node) {
278 DCHECK(node->opcode() == IrOpcode::kJSStoreNamed); 278 DCHECK(node->opcode() == IrOpcode::kJSStoreNamed);
279 if (true) return NoChange(); // TODO(titzer): storenamed is broken
279 Node* frame_state_before = GetFrameStateBefore(node); 280 Node* frame_state_before = GetFrameStateBefore(node);
280 if (frame_state_before == nullptr) return NoChange(); 281 if (frame_state_before == nullptr) return NoChange();
281 282
282 TypeFeedbackId id = js_type_feedback_->find(node); 283 TypeFeedbackId id = js_type_feedback_->find(node);
283 if (id.IsNone() || oracle()->StoreIsUninitialized(id)) return NoChange(); 284 if (id.IsNone() || oracle()->StoreIsUninitialized(id)) return NoChange();
284 285
285 const StoreNamedParameters& p = StoreNamedParametersOf(node->op()); 286 const StoreNamedParameters& p = StoreNamedParametersOf(node->op());
286 SmallMapList maps; 287 SmallMapList maps;
287 Handle<Name> name = p.name().handle(); 288 Handle<Name> name = p.name().handle();
288 Node* receiver = node->InputAt(0); 289 Node* receiver = node->InputAt(0);
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
375 BailoutId id = OpParameter<FrameStateCallInfo>(node).bailout_id(); 376 BailoutId id = OpParameter<FrameStateCallInfo>(node).bailout_id();
376 if (id != BailoutId::None()) return frame_state; 377 if (id != BailoutId::None()) return frame_state;
377 } 378 }
378 } 379 }
379 return nullptr; 380 return nullptr;
380 } 381 }
381 382
382 } // namespace compiler 383 } // namespace compiler
383 } // namespace internal 384 } // namespace internal
384 } // namespace v8 385 } // namespace v8
OLDNEW
« no previous file with comments | « no previous file | src/flag-definitions.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698