[Smart Lock] Prettify android:// URIs shown on "Passwords page" for Clank.

[Smart Lock] Prettify android:// URIs shown on "Passwords page" for Clank.

Password setting page should show android URLs (e.g.
android://hash@com.example.android/path) in human readable form (android://com.example.android/path) for both saved passwords and exceptions.

BUG=486736
Committed: https://crrev.com/50849886c557ce3538368935b755dc5e331006c7
Cr-Commit-Position: refs/heads/master@{#329633}

[melandory, 2015-05-13 12:48:34]

melandory@chromium.org changed reviewers:
+ bauerb@chromium.org, engedy@chromium.org

[melandory, 2015-05-13 12:48:34]

Hi Bernhard,

do you have time to review this CL? We want to have this issue fixed until M44
(probably merge to M43).

Thanks in advance.

[Bernhard Bauer, 2015-05-13 13:18:24]

lgtm

[vabr (Chromium), 2015-05-13 13:21:20]

vabr@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2015-05-13 13:21:20]

(FWIW LGTM. Vaclav)

[engedy, 2015-05-13 13:22:34]

engedy@chromium.org changed reviewers:
- vabr@chromium.org

[engedy, 2015-05-13 13:22:35]

Tanja, thanks a lot for looking into this, the CL looks good, I have just one
more feature request, please see below.

Also, one nit: as there will be no path for android:// URIs, I think we can drop
that part in the example in the CL description.

https://codereview.chromium.org/1140943002/diff/1/chrome/browser/android/pass...
File chrome/browser/android/password_ui_view_android.cc (right):

https://codereview.chromium.org/1140943002/diff/1/chrome/browser/android/pass...
chrome/browser/android/password_ui_view_android.cc:93: return
ConvertUTF8ToJavaString(env, form->origin.spec());
As I have recently learned, we will also need the prettification for blacklist
items too.

[melandory, 2015-05-13 13:29:16]

https://codereview.chromium.org/1140943002/diff/1/chrome/browser/android/pass...
File chrome/browser/android/password_ui_view_android.cc (right):

https://codereview.chromium.org/1140943002/diff/1/chrome/browser/android/pass...
chrome/browser/android/password_ui_view_android.cc:93: return
ConvertUTF8ToJavaString(env, form->origin.spec());
On 2015/05/13 13:22:34, engedy wrote:
> As I have recently learned, we will also need the prettification for blacklist
> items too.

Done. Thanks for catching this issue!

[engedy, 2015-05-13 13:31:52]

On 2015/05/13 13:29:16, melandory wrote:
>
https://codereview.chromium.org/1140943002/diff/1/chrome/browser/android/pass...
> File chrome/browser/android/password_ui_view_android.cc (right):
> 
>
https://codereview.chromium.org/1140943002/diff/1/chrome/browser/android/pass...
> chrome/browser/android/password_ui_view_android.cc:93: return
> ConvertUTF8ToJavaString(env, form->origin.spec());
> On 2015/05/13 13:22:34, engedy wrote:
> > As I have recently learned, we will also need the prettification for
blacklist
> > items too.
> 
> Done. Thanks for catching this issue!

LGTM, thanks!

[melandory, 2015-05-13 14:24:58]

The CQ bit was checked by melandory@chromium.org

[melandory, 2015-05-13 14:24:59]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1140943002/#ps20001
(title: "Human readable URL for exceptions.")

[commit-bot: I haz the power, 2015-05-13 14:25:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1140943002/20001

[commit-bot: I haz the power, 2015-05-13 14:29:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-13 14:30:06]

Patchset 2 (id:??) landed as
https://crrev.com/50849886c557ce3538368935b755dc5e331006c7
Cr-Commit-Position: refs/heads/master@{#329633}