[Smart Lock] Prettify android:// URIs shown on "Passwords page" for Clank.

chrome/browser/android/password_ui_view_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/password_ui_view_android.h"
 
 #include "base/android/jni_string.h"
 #include "base/android/jni_weak_ref.h"
 #include "base/command_line.h"
 #include "base/metrics/field_trial.h"
+#include "base/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/ui/passwords/manage_passwords_view_utils.h"
+#include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "components/autofill/core/common/password_form.h"
 #include "components/password_manager/core/common/experiments.h"
 #include "components/password_manager/core/common/password_manager_switches.h"
 #include "jni/PasswordUIView_jni.h"
 
 using base::android::ConvertUTF16ToJavaString;
 using base::android::ConvertUTF8ToJavaString;
 using base::android::ScopedJavaLocalRef;
 
@@ skipping 44 matching lines @@
 ScopedJavaLocalRef<jobject>
 PasswordUIViewAndroid::GetSavedPasswordEntry(JNIEnv* env, jobject, int index) {
   const autofill::PasswordForm* form =
       password_manager_presenter_.GetPassword(index);
   if (!form) {
     return Java_PasswordUIView_createSavedPasswordEntry(
         env,
         ConvertUTF8ToJavaString(env, std::string()).obj(),
         ConvertUTF16ToJavaString(env, base::string16()).obj());
   }
+  std::string human_readable_origin = GetHumanReadableOrigin(
+      *form, GetProfile()->GetPrefs()->GetString(prefs::kAcceptLanguages));
   return Java_PasswordUIView_createSavedPasswordEntry(
-      env,
-      ConvertUTF8ToJavaString(env, form->origin.spec()).obj(),
+      env, ConvertUTF8ToJavaString(
+               env, human_readable_origin).obj(),
       ConvertUTF16ToJavaString(env, form->username_value).obj());
 }
 
 ScopedJavaLocalRef<jstring> PasswordUIViewAndroid::GetSavedPasswordException(
     JNIEnv* env, jobject, int index) {
   const autofill::PasswordForm* form =
       password_manager_presenter_.GetPasswordException(index);
   if (!form)
     return ConvertUTF8ToJavaString(env, std::string());
   return ConvertUTF8ToJavaString(env, form->origin.spec());

[engedy, 2015/05/13 13:22:34]

As I have recently learned, we will also need the prettification for blacklist
items too.

[melandory, 2015/05/13 13:29:16]

Done. Thanks for catching this issue!

 }
 
 void PasswordUIViewAndroid::HandleRemoveSavedPasswordEntry(
     JNIEnv* env, jobject, int index) {
   password_manager_presenter_.RemoveSavedPassword(index);
 }
 
 void PasswordUIViewAndroid::HandleRemoveSavedPasswordException(
     JNIEnv* env, jobject, int index) {
   password_manager_presenter_.RemovePasswordException(index);
@@ skipping 11 matching lines @@
 
 // static
 static jlong Init(JNIEnv* env, jobject obj) {
   PasswordUIViewAndroid* controller = new PasswordUIViewAndroid(env, obj);
   return reinterpret_cast<intptr_t>(controller);
 }
 
 bool PasswordUIViewAndroid::RegisterPasswordUIViewAndroid(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }