Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Unified Diff: chrome/browser/chromeos/launcher_search_provider/service.h

Issue 1140873002: Change queryId of launcherSearchProvider API to integer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/launcher_search_provider/service.h
diff --git a/chrome/browser/chromeos/launcher_search_provider/service.h b/chrome/browser/chromeos/launcher_search_provider/service.h
index a27165cfaf228b2044d85325856aa5c4aa6ff14e..17ebf97ce8d989bf33403f8666cbdf10e10f3779 100644
--- a/chrome/browser/chromeos/launcher_search_provider/service.h
+++ b/chrome/browser/chromeos/launcher_search_provider/service.h
@@ -53,7 +53,7 @@ class Service : public KeyedService {
void SetSearchResults(
const extensions::Extension* extension,
scoped_ptr<ErrorReporter> error_reporter,
- const std::string& query_id,
+ const int query_id,
oshima 2015/05/13 16:02:01 shouldn't this be int64?
yawano 2015/05/14 00:44:44 Sorry, why? Type in the generated code from idl is
oshima 2015/05/14 01:26:11 Sorry, I must be sleeping or something. I somehow
yawano 2015/05/14 03:19:24 Acknowledged.
const std::vector<linked_ptr<
extensions::api::launcher_search_provider::SearchResult>>& results);
@@ -67,7 +67,7 @@ class Service : public KeyedService {
Profile* const profile_;
extensions::ExtensionRegistry* extension_registry_;
app_list::LauncherSearchProvider* provider_;
- uint32 query_id_;
+ int query_id_;
yawano 2015/05/13 07:33:42 Changed this to int per code style: https://google
bool is_query_running_;
DISALLOW_COPY_AND_ASSIGN(Service);

Powered by Google App Engine
This is Rietveld 408576698