Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Side by Side Diff: chrome/browser/chromeos/launcher_search_provider/service.h

Issue 1140873002: Change queryId of launcherSearchProvider API to integer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CHROMEOS_LAUNCHER_SEARCH_PROVIDER_SERVICE_H_ 5 #ifndef CHROME_BROWSER_CHROMEOS_LAUNCHER_SEARCH_PROVIDER_SERVICE_H_
6 #define CHROME_BROWSER_CHROMEOS_LAUNCHER_SEARCH_PROVIDER_SERVICE_H_ 6 #define CHROME_BROWSER_CHROMEOS_LAUNCHER_SEARCH_PROVIDER_SERVICE_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "chrome/browser/chromeos/launcher_search_provider/error_reporter.h" 9 #include "chrome/browser/chromeos/launcher_search_provider/error_reporter.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 void OnQueryEnded(); 46 void OnQueryEnded();
47 47
48 // Dispatches onOpenResult event of |item_id| to |extension_id|. 48 // Dispatches onOpenResult event of |item_id| to |extension_id|.
49 void OnOpenResult(const extensions::ExtensionId& extension_id, 49 void OnOpenResult(const extensions::ExtensionId& extension_id,
50 const std::string& item_id); 50 const std::string& item_id);
51 51
52 // Sets search results of a listener extension. 52 // Sets search results of a listener extension.
53 void SetSearchResults( 53 void SetSearchResults(
54 const extensions::Extension* extension, 54 const extensions::Extension* extension,
55 scoped_ptr<ErrorReporter> error_reporter, 55 scoped_ptr<ErrorReporter> error_reporter,
56 const std::string& query_id, 56 const int query_id,
oshima 2015/05/13 16:02:01 shouldn't this be int64?
yawano 2015/05/14 00:44:44 Sorry, why? Type in the generated code from idl is
oshima 2015/05/14 01:26:11 Sorry, I must be sleeping or something. I somehow
yawano 2015/05/14 03:19:24 Acknowledged.
57 const std::vector<linked_ptr< 57 const std::vector<linked_ptr<
58 extensions::api::launcher_search_provider::SearchResult>>& results); 58 extensions::api::launcher_search_provider::SearchResult>>& results);
59 59
60 // Returns true if there is a running query. 60 // Returns true if there is a running query.
61 bool IsQueryRunning() const; 61 bool IsQueryRunning() const;
62 62
63 private: 63 private:
64 // Returns extension ids of listener extensions. 64 // Returns extension ids of listener extensions.
65 std::set<extensions::ExtensionId> GetListenerExtensionIds(); 65 std::set<extensions::ExtensionId> GetListenerExtensionIds();
66 66
67 Profile* const profile_; 67 Profile* const profile_;
68 extensions::ExtensionRegistry* extension_registry_; 68 extensions::ExtensionRegistry* extension_registry_;
69 app_list::LauncherSearchProvider* provider_; 69 app_list::LauncherSearchProvider* provider_;
70 uint32 query_id_; 70 int query_id_;
yawano 2015/05/13 07:33:42 Changed this to int per code style: https://google
71 bool is_query_running_; 71 bool is_query_running_;
72 72
73 DISALLOW_COPY_AND_ASSIGN(Service); 73 DISALLOW_COPY_AND_ASSIGN(Service);
74 }; 74 };
75 75
76 } // namespace launcher_search_provider 76 } // namespace launcher_search_provider
77 } // namespace chromeos 77 } // namespace chromeos
78 78
79 #endif // CHROME_BROWSER_CHROMEOS_LAUNCHER_SEARCH_PROVIDER_SERVICE_H_ 79 #endif // CHROME_BROWSER_CHROMEOS_LAUNCHER_SEARCH_PROVIDER_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698