Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: content/browser/appcache/appcache_disk_cache.h

Issue 1140853002: ServiceWorker: Use SimpleCache for the script cache (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix for review comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/appcache/appcache_disk_cache.h
diff --git a/content/browser/appcache/appcache_disk_cache.h b/content/browser/appcache/appcache_disk_cache.h
index 8995e83cf719db91571925f8437a078cbbcf88a1..612c68d8ad0515d93993a78f3f18aec2f7ee872a 100644
--- a/content/browser/appcache/appcache_disk_cache.h
+++ b/content/browser/appcache/appcache_disk_cache.h
@@ -52,6 +52,9 @@ class CONTENT_EXPORT AppCacheDiskCache
const net::CompletionCallback& callback) override;
int DoomEntry(int64 key, const net::CompletionCallback& callback) override;
+ protected:
+ explicit AppCacheDiskCache(bool use_simple_cache);
+
private:
class CreateBackendCallbackShim;
class EntryImpl;
@@ -101,7 +104,8 @@ class CONTENT_EXPORT AppCacheDiskCache
void AddOpenEntry(EntryImpl* entry) { open_entries_.insert(entry); }
void RemoveOpenEntry(EntryImpl* entry) { open_entries_.erase(entry); }
- bool is_disabled_;
+ bool use_simple_cache_ = false;
kinuko 2015/05/15 02:28:48 nit: we initialize this differently in ctors, it's
nhiroki 2015/05/15 03:02:47 Done.
+ bool is_disabled_ = false;
net::CompletionCallback init_callback_;
scoped_refptr<CreateBackendCallbackShim> create_backend_callback_;
PendingCalls pending_calls_;
« no previous file with comments | « no previous file | content/browser/appcache/appcache_disk_cache.cc » ('j') | content/browser/appcache/appcache_disk_cache.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698