ServiceWorker: Use SimpleCache for the script cache

content/browser/appcache/appcache_disk_cache.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_APPCACHE_APPCACHE_DISK_CACHE_H_
 #define CONTENT_BROWSER_APPCACHE_APPCACHE_DISK_CACHE_H_
 
 #include <set>
 #include <vector>
 
@@ skipping 34 matching lines @@
   bool is_disabled() const { return is_disabled_; }
 
   int CreateEntry(int64 key,
                   Entry** entry,
                   const net::CompletionCallback& callback) override;
   int OpenEntry(int64 key,
                 Entry** entry,
                 const net::CompletionCallback& callback) override;
   int DoomEntry(int64 key, const net::CompletionCallback& callback) override;
 
+ protected:
+  explicit AppCacheDiskCache(bool use_simple_cache);
+
  private:
   class CreateBackendCallbackShim;
   class EntryImpl;
 
   // PendingCalls allow CreateEntry, OpenEntry, and DoomEntry to be called
   // immediately after construction, without waiting for the
   // underlying disk_cache::Backend to be fully constructed. Early
   // calls are queued up and serviced once the disk_cache::Backend is
   // really ready to go.
   enum PendingCallType {
@@ skipping 29 matching lines @@
            int cache_size,
            bool force,
            const scoped_refptr<base::SingleThreadTaskRunner>& cache_thread,
            const net::CompletionCallback& callback);
   void OnCreateBackendComplete(int rv);
   void AddActiveCall(ActiveCall* call) { active_calls_.insert(call); }
   void RemoveActiveCall(ActiveCall* call) { active_calls_.erase(call); }
   void AddOpenEntry(EntryImpl* entry) { open_entries_.insert(entry); }
   void RemoveOpenEntry(EntryImpl* entry) { open_entries_.erase(entry); }
 
-  bool is_disabled_;
+  bool use_simple_cache_ = false;

[kinuko, 2015/05/15 02:28:48]

nit: we initialize this differently in ctors, it's probably not the best use of
in-class member initialization.

nit: and if that's the case probably we can just leave is_disabled_
initialization in ctors too (it's optional, but having all initialization in one
place is preferred in general)

[nhiroki, 2015/05/15 03:02:47]

Done.

+  bool is_disabled_ = false;
   net::CompletionCallback init_callback_;
   scoped_refptr<CreateBackendCallbackShim> create_backend_callback_;
   PendingCalls pending_calls_;
   ActiveCalls active_calls_;
   OpenEntries open_entries_;
   scoped_ptr<disk_cache::Backend> disk_cache_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_APPCACHE_APPCACHE_DISK_CACHE_H_