Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1140813004: bluetooth: Add EXPORT macro to BluetoothAdapter::Observer. (Closed)

Created:
5 years, 7 months ago by ortuno
Modified:
5 years, 7 months ago
Reviewers:
scheib, armansito
CC:
chromium-reviews, scheib+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Add EXPORT macro to BluetoothAdapter::Observer. Component build requires EXPORT macro when code from content utilizes this class, as used in upcoming https://codereview.chromium.org/1125133005 BUG=489330 Committed: https://crrev.com/ad1b429e966f9f0fcaceb60938c7a00fe36c5cb1 Cr-Commit-Position: refs/heads/master@{#330626}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M device/bluetooth/bluetooth_adapter.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
ortuno
@armansito: Pretty small change. PTAL
5 years, 7 months ago (2015-05-15 23:17:03 UTC) #3
scheib
LGTM but fix up description text: e.g. something like: Component build requires EXPORT macro when ...
5 years, 7 months ago (2015-05-16 00:24:10 UTC) #5
ortuno
On 2015/05/15 at 23:17:03, ortuno wrote: > @armansito: Pretty small change. PTAL @armansito: ping?
5 years, 7 months ago (2015-05-18 17:54:42 UTC) #6
ortuno
On 2015/05/16 at 00:24:10, scheib wrote: > LGTM but fix up description text: e.g. something ...
5 years, 7 months ago (2015-05-18 17:56:02 UTC) #7
armansito
lgtm
5 years, 7 months ago (2015-05-19 20:19:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140813004/20001
5 years, 7 months ago (2015-05-19 20:21:38 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-19 22:02:52 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 22:03:30 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ad1b429e966f9f0fcaceb60938c7a00fe36c5cb1
Cr-Commit-Position: refs/heads/master@{#330626}

Powered by Google App Engine
This is Rietveld 408576698