bluetooth: Move testing IPC from BluetoothDispatcher to BlinkTestRunner

bluetooth: Move testing IPC from BluetoothDispatcher to BlinkTestRunner

This patch removes the testing IPC from BluetoothDispatcher and
BluetoothDispatcherHost.

This patch also changes the way the mock BluetoothAdapter was set in
BluetoothDispatcherHost. Instead of receiving an IPC to set the adapter,
BluetoothDispatcherHost exposes a function to directly set the adapter.
This function is used by LayoutTestSupport to set the adapter.

Mock adapter flow before:
BlinkTestRunner -> LayoutTestSupport -> BluetoothDispatcher --IPC-->
BluetoothDispatcherHost (Mock constructed here)

After:
BlinkTestRunner --IPC--> LayoutTestMessages(Mock constructed here) ->
LayoutTestSupport -> BluetoothDispatcherHost

This is the first of two patches to remove testing from BluetoothDispatcher
and BluetoothDispatcherHost:

 [1] This patch.
 [2] http://crrev.com/1132943002

BUG=436284
Committed: https://crrev.com/3f7142d0acf5e930743cbe5d754084c464ac3c85
Cr-Commit-Position: refs/heads/master@{#330647}

Committed: https://crrev.com/a58d60c749f55046a8a85c6398864759fd877266
Cr-Commit-Position: refs/heads/master@{#330696}

[ortuno, 2015-05-15 01:05:13]

Patchset #1 (id:1) has been deleted

[ortuno, 2015-05-15 16:55:01]

Patchset #1 (id:20001) has been deleted

[ortuno, 2015-05-15 16:55:09]

Patchset #1 (id:40001) has been deleted

[ortuno, 2015-05-15 17:22:15]

Patchset #1 (id:60001) has been deleted

[ortuno, 2015-05-15 17:22:25]

Patchset #1 (id:60001) has been deleted

[ortuno, 2015-05-15 17:22:35]

Patchset #1 (id:60001) has been deleted

[ortuno, 2015-05-15 17:32:59]

Patchset #1 (id:80001) has been deleted

[ortuno, 2015-05-15 21:51:49]

Patchset #1 (id:100001) has been deleted

[ortuno, 2015-05-15 21:51:57]

Patchset #1 (id:120001) has been deleted

[ortuno, 2015-05-15 21:52:04]

Patchset #1 (id:140001) has been deleted

[ortuno, 2015-05-15 21:52:09]

Patchset #1 (id:90017) has been deleted

[ortuno, 2015-05-15 22:48:26]

Patchset #1 (id:170001) has been deleted

[ortuno, 2015-05-15 23:01:43]

Patchset #1 (id:190001) has been deleted

[ortuno, 2015-05-15 23:17:25]

Patchset #1 (id:210001) has been deleted

[ortuno, 2015-05-15 23:26:10]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2015-05-15 23:26:11]

scheib: PTAL

[scheib, 2015-05-16 01:00:35]

https://codereview.chromium.org/1125133005/diff/230001/content/browser/blueto...
File content/browser/bluetooth/bluetooth_dispatcher_host.cc (right):

https://codereview.chromium.org/1125133005/diff/230001/content/browser/blueto...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:136: void
BluetoothDispatcherHost::SetBluetoothAdapterForTesting(
Move to match declaration order.

https://codereview.chromium.org/1125133005/diff/230001/content/browser/blueto...
File content/browser/bluetooth/bluetooth_dispatcher_host.h (right):

https://codereview.chromium.org/1125133005/diff/230001/content/browser/blueto...
content/browser/bluetooth/bluetooth_dispatcher_host.h:37: void
SetBluetoothAdapterForTesting(const std::string& name);
Make this match the signature you'll use in
https://codereview.chromium.org/1132943002/

https://codereview.chromium.org/1125133005/diff/230001/content/public/test/la...
File content/public/test/layouttest_support.h (right):

https://codereview.chromium.org/1125133005/diff/230001/content/public/test/la...
content/public/test/layouttest_support.h:97: void SetBluetoothAdapter(int
render_process_id, const std::string& name);
Update to match
https://codereview.chromium.org/1132943002/diff/370001/content/public/test/la...

https://codereview.chromium.org/1125133005/diff/230001/content/shell/browser/...
File content/shell/browser/layout_test/layout_test_message_filter.h (right):

https://codereview.chromium.org/1125133005/diff/230001/content/shell/browser/...
content/shell/browser/layout_test/layout_test_message_filter.h:67: 
Keep in same block as above.

https://codereview.chromium.org/1125133005/diff/230001/content/shell/common/l...
File content/shell/common/layout_test/layout_test_messages.h (right):

https://codereview.chromium.org/1125133005/diff/230001/content/shell/common/l...
content/shell/common/layout_test/layout_test_messages.h:41: 
Stay consistent with above, no blank line.

[jam, 2015-05-18 15:37:57]

jam@chromium.org changed reviewers:
+ jam@chromium.org

[jam, 2015-05-18 15:37:58]

lgtm

https://codereview.chromium.org/1125133005/diff/230001/content/test/layouttes...
File content/test/layouttest_support.cc (right):

https://codereview.chromium.org/1125133005/diff/230001/content/test/layouttes...
content/test/layouttest_support.cc:326: DCHECK(bdh);
nit: remove all dchecks from this method.

the first one isn't needed because RenderProcessHost::FromID already does. the
second one isn't needed because 325 would crash if the pointer is null, which is
just as useful of a signal. ditto for line 326

[scheib, 2015-05-18 16:43:30]

LGTM

https://codereview.chromium.org/1125133005/diff/230001/content/browser/blueto...
File content/browser/bluetooth/bluetooth_dispatcher_host.h (right):

https://codereview.chromium.org/1125133005/diff/230001/content/browser/blueto...
content/browser/bluetooth/bluetooth_dispatcher_host.h:37: void
SetBluetoothAdapterForTesting(const std::string& name);
On 2015/05/16 01:00:35, scheib wrote:
> Make this match the signature you'll use in
> https://codereview.chromium.org/1132943002/

Sorry, my miss-reading here. Fine to have this signature.

[ortuno, 2015-05-18 17:40:17]

https://codereview.chromium.org/1125133005/diff/230001/content/browser/blueto...
File content/browser/bluetooth/bluetooth_dispatcher_host.cc (right):

https://codereview.chromium.org/1125133005/diff/230001/content/browser/blueto...
content/browser/bluetooth/bluetooth_dispatcher_host.cc:136: void
BluetoothDispatcherHost::SetBluetoothAdapterForTesting(
On 2015/05/16 at 01:00:34, scheib wrote:
> Move to match declaration order.

Done.

https://codereview.chromium.org/1125133005/diff/230001/content/public/test/la...
File content/public/test/layouttest_support.h (right):

https://codereview.chromium.org/1125133005/diff/230001/content/public/test/la...
content/public/test/layouttest_support.h:97: void SetBluetoothAdapter(int
render_process_id, const std::string& name);
On 2015/05/16 at 01:00:35, scheib wrote:
> Update to match
https://codereview.chromium.org/1132943002/diff/370001/content/public/test/la...

The signature has to change twice.

https://codereview.chromium.org/1125133005/diff/230001/content/shell/browser/...
File content/shell/browser/layout_test/layout_test_message_filter.h (right):

https://codereview.chromium.org/1125133005/diff/230001/content/shell/browser/...
content/shell/browser/layout_test/layout_test_message_filter.h:67: 
On 2015/05/16 at 01:00:35, scheib wrote:
> Keep in same block as above.

Done.

https://codereview.chromium.org/1125133005/diff/230001/content/shell/common/l...
File content/shell/common/layout_test/layout_test_messages.h (right):

https://codereview.chromium.org/1125133005/diff/230001/content/shell/common/l...
content/shell/common/layout_test/layout_test_messages.h:41: 
On 2015/05/16 at 01:00:35, scheib wrote:
> Stay consistent with above, no blank line.

Done.

https://codereview.chromium.org/1125133005/diff/230001/content/test/layouttes...
File content/test/layouttest_support.cc (right):

https://codereview.chromium.org/1125133005/diff/230001/content/test/layouttes...
content/test/layouttest_support.cc:326: DCHECK(bdh);
On 2015/05/18 at 15:37:57, jam wrote:
> nit: remove all dchecks from this method.
> 
> the first one isn't needed because RenderProcessHost::FromID already does. the
second one isn't needed because 325 would crash if the pointer is null, which is
just as useful of a signal. ditto for line 326

Done.

[ortuno, 2015-05-18 17:52:47]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2015-05-18 17:52:48]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1125133005/#ps250001
(title: "Fixes based on comments"")

[commit-bot: I haz the power, 2015-05-18 17:53:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1125133005/250001

[ortuno, 2015-05-18 17:55:12]

The CQ bit was unchecked by ortuno@chromium.org

[ortuno, 2015-05-19 22:04:43]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2015-05-19 22:07:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1125133005/250001

[commit-bot: I haz the power, 2015-05-19 22:15:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-19 22:16:01]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[ortuno, 2015-05-19 22:18:11]

ortuno@chromium.org changed reviewers:
+ tsepez@chromium.org

[ortuno, 2015-05-19 22:18:12]

@tsepez: Please OWNERS review for content/common/bluetooth/bluetooth_messages.h

[Tom Sepez, 2015-05-19 22:45:17]

lgtm

[ortuno, 2015-05-19 22:45:43]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2015-05-19 22:45:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1125133005/250001

[commit-bot: I haz the power, 2015-05-19 22:56:01]

Committed patchset #2 (id:250001)

[commit-bot: I haz the power, 2015-05-19 22:56:58]

Patchset 2 (id:??) landed as
https://crrev.com/3f7142d0acf5e930743cbe5d754084c464ac3c85
Cr-Commit-Position: refs/heads/master@{#330647}

[leviw_travelin_and_unemployed, 2015-05-20 00:18:09]

A revert of this CL (patchset #2 id:250001) has been created in
https://codereview.chromium.org/1142303002/ by leviw@chromium.org.

The reason for reverting is: Broke a bunch of Layout Tests. Here's an example:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpec...

STDERR: ==28151==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000050
(pc 0x000006a00bd0 bp 0x7fff171be890 sp 0x7fff171be880 T0)
STDERR:     #0 0x6a00bcf in
content::BluetoothDispatcherHost::SetBluetoothAdapterForTesting(std::__1::basic_string<char,
std::__1::char_traits<char>, std::__1::allocator<char> > const&)
content/browser/bluetooth/bluetooth_dispatcher_host.cc:63:43
STDERR:     #1 0x4e5d9d in OnSetBluetoothAdapter
content/shell/browser/layout_test/layout_test_message_filter.cc:171:3
STDERR:     #2 0x4e5d9d in
DispatchToMethodImpl<content::LayoutTestMessageFilter, void
(content::LayoutTestMessageFilter::*)(const std::__1::basic_string<char> &),
std::__1::basic_string<char> , 0> base/tuple.h:252:0
.

[ortuno, 2015-05-20 02:46:00]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2015-05-20 02:46:01]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org,
scheib@chromium.org, jam@chromium.org
Link to the patchset: https://codereview.chromium.org/1125133005/#ps270001
(title: "Fix for stable release mode tests")

[ortuno, 2015-05-20 02:46:13]

The CQ bit was unchecked by ortuno@chromium.org

[commit-bot: I haz the power, 2015-05-20 02:46:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1125133005/270001

[ortuno, 2015-05-20 02:46:59]

The CQ bit was checked by ortuno@chromium.org

[commit-bot: I haz the power, 2015-05-20 02:47:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1125133005/270001

[scheib, 2015-05-20 04:21:27]

https://codereview.chromium.org/1125133005/diff/270001/content/test/layouttes...
File content/test/layouttest_support.cc (right):

https://codereview.chromium.org/1125133005/diff/270001/content/test/layouttes...
content/test/layouttest_support.cc:324: if (dispatcher_host != NULL)
Just "if (dispatcher_host)" in C++

[commit-bot: I haz the power, 2015-05-20 04:42:23]

Committed patchset #3 (id:270001)

[commit-bot: I haz the power, 2015-05-20 04:43:15]

Patchset 3 (id:??) landed as
https://crrev.com/a58d60c749f55046a8a85c6398864759fd877266
Cr-Commit-Position: refs/heads/master@{#330696}