Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1140813003: NTP Zombie Code Slayer III, The Saga Continues: Foreign Sessions (Closed)

Created:
5 years, 7 months ago by Dan Beam
Modified:
5 years, 7 months ago
Reviewers:
Mark P, Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, pedrosimonetti+watch_chromium.org, Patrick Dubroy, pam+watch_chromium.org, jlklein+watch-closure_chromium.org, asvitkine+watch_chromium.org, estade+watch_chromium.org, vitalyp+closure_chromium.org, dbeam+watch-closure_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@suggestions-page
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NTP Zombie Code Slayer III, The Saga Continues: Foreign Sessions Foreign sessions is an old feature that showed pages from other devices on the new tab page. It has since been removed. It was added by a contributor that has since left chrome (dubroy@). What it used to look like: http://bit.ly/1PLDgea R=estade@chromium.org BUG=329637 Committed: https://crrev.com/75883e44acc05552a69f7958684179f8cf209f1c Cr-Commit-Position: refs/heads/master@{#330466}

Patch Set 1 : found more zombies #

Total comments: 7

Patch Set 2 : histograms.xml rename #

Total comments: 4

Patch Set 3 : estade@ review #

Total comments: 4

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1073 lines) Patch
M build/ios/grit_whitelist.txt View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 3 chunks +12 lines, -29 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/resources/history/other_devices.js View 1 2 3 3 chunks +2 lines, -7 lines 0 comments Download
M chrome/browser/resources/ntp4/compiled_resources.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/ntp4/new_tab.css View 1 chunk +0 lines, -16 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.html View 3 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/resources/ntp4/new_tab.js View 5 chunks +0 lines, -27 lines 0 comments Download
D chrome/browser/resources/ntp4/other_sessions.js View 1 chunk +0 lines, -386 lines 0 comments Download
A + chrome/browser/ui/webui/foreign_session_handler.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/webui/foreign_session_handler.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/history_ui.cc View 2 chunks +5 lines, -5 lines 0 comments Download
D chrome/browser/ui/webui/ntp/foreign_session_handler.h View 1 chunk +0 lines, -105 lines 0 comments Download
D chrome/browser/ui/webui/ntp/foreign_session_handler.cc View 1 chunk +0 lines, -423 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 4 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/ui/webui/ntp/ntp_resource_cache.cc View 3 chunks +0 lines, -18 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +0 lines, -3 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 4 chunks +17 lines, -14 lines 0 comments Download

Messages

Total messages: 21 (5 generated)
Dan Beam
5 years, 7 months ago (2015-05-15 23:10:17 UTC) #2
Dan Beam
+mpearson@ for tools/metrics
5 years, 7 months ago (2015-05-15 23:15:20 UTC) #4
Mark P
https://codereview.chromium.org/1140813003/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1140813003/diff/20001/tools/metrics/histograms/histograms.xml#oldcode25036 tools/metrics/histograms/histograms.xml:25036: -<histogram name="NewTabPage.OtherSessionsMenu" enum="NtpOtherSessionsType"> Never delete old histograms; instead mark ...
5 years, 7 months ago (2015-05-15 23:19:39 UTC) #5
Dan Beam
https://codereview.chromium.org/1140813003/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (left): https://codereview.chromium.org/1140813003/diff/20001/tools/metrics/histograms/histograms.xml#oldcode25036 tools/metrics/histograms/histograms.xml:25036: -<histogram name="NewTabPage.OtherSessionsMenu" enum="NtpOtherSessionsType"> On 2015/05/15 23:19:39, Mark P wrote: ...
5 years, 7 months ago (2015-05-15 23:38:52 UTC) #6
Dan Beam
https://codereview.chromium.org/1140813003/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1140813003/diff/20001/tools/metrics/histograms/histograms.xml#newcode12495 tools/metrics/histograms/histograms.xml:12495: +<histogram name="HistoryPage.OtherDevicesMenu" enum="HistoryOtherDevicesType"> On 2015/05/15 23:38:52, Dan Beam wrote: ...
5 years, 7 months ago (2015-05-16 00:10:12 UTC) #7
Mark P
histograms.xml lgtm
5 years, 7 months ago (2015-05-17 04:08:44 UTC) #8
Evan Stade
https://codereview.chromium.org/1140813003/diff/60001/chrome/browser/resources/history/other_devices.js File chrome/browser/resources/history/other_devices.js (right): https://codereview.chromium.org/1140813003/diff/60001/chrome/browser/resources/history/other_devices.js#newcode560 chrome/browser/resources/history/other_devices.js:560: // TODO(dbeam): why is this call NTP-specific? Doesn't make ...
5 years, 7 months ago (2015-05-18 18:02:15 UTC) #10
Dan Beam
https://codereview.chromium.org/1140813003/diff/60001/chrome/browser/resources/history/other_devices.js File chrome/browser/resources/history/other_devices.js (right): https://codereview.chromium.org/1140813003/diff/60001/chrome/browser/resources/history/other_devices.js#newcode560 chrome/browser/resources/history/other_devices.js:560: // TODO(dbeam): why is this call NTP-specific? Doesn't make ...
5 years, 7 months ago (2015-05-18 18:24:23 UTC) #11
Evan Stade
https://codereview.chromium.org/1140813003/diff/80001/chrome/browser/resources/history/other_devices.js File chrome/browser/resources/history/other_devices.js (right): https://codereview.chromium.org/1140813003/diff/80001/chrome/browser/resources/history/other_devices.js#newcode560 chrome/browser/resources/history/other_devices.js:560: // TODO(dbeam): why is the ntp.* namespace being used ...
5 years, 7 months ago (2015-05-18 18:28:59 UTC) #12
Dan Beam
https://codereview.chromium.org/1140813003/diff/80001/chrome/browser/resources/history/other_devices.js File chrome/browser/resources/history/other_devices.js (right): https://codereview.chromium.org/1140813003/diff/80001/chrome/browser/resources/history/other_devices.js#newcode560 chrome/browser/resources/history/other_devices.js:560: // TODO(dbeam): why is the ntp.* namespace being used ...
5 years, 7 months ago (2015-05-18 18:38:16 UTC) #13
Evan Stade
https://codereview.chromium.org/1140813003/diff/80001/chrome/browser/resources/history/other_devices.js File chrome/browser/resources/history/other_devices.js (right): https://codereview.chromium.org/1140813003/diff/80001/chrome/browser/resources/history/other_devices.js#newcode560 chrome/browser/resources/history/other_devices.js:560: // TODO(dbeam): why is the ntp.* namespace being used ...
5 years, 7 months ago (2015-05-18 18:49:08 UTC) #14
Dan Beam
https://codereview.chromium.org/1140813003/diff/80001/chrome/browser/resources/history/other_devices.js File chrome/browser/resources/history/other_devices.js (right): https://codereview.chromium.org/1140813003/diff/80001/chrome/browser/resources/history/other_devices.js#newcode560 chrome/browser/resources/history/other_devices.js:560: // TODO(dbeam): why is the ntp.* namespace being used ...
5 years, 7 months ago (2015-05-18 20:00:35 UTC) #15
Evan Stade
lgtm you probably need to update some gn files
5 years, 7 months ago (2015-05-18 20:17:08 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140813003/100001
5 years, 7 months ago (2015-05-19 00:37:09 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 7 months ago (2015-05-19 01:34:33 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 01:35:28 UTC) #21
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/75883e44acc05552a69f7958684179f8cf209f1c
Cr-Commit-Position: refs/heads/master@{#330466}

Powered by Google App Engine
This is Rietveld 408576698