Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 1140813003: NTP Zombie Code Slayer III, The Saga Continues: Foreign Sessions (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@suggestions-page
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index a7019e3dca6785a46bd0e7747a3d286040faaf76..193fd312dcde797b86c9dc969261ee00e23722f4 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -12547,7 +12547,7 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
-<histogram name="HistoryPage.OtherDevicesMenu" enum="NtpOtherSessionsType">
+<histogram name="HistoryPage.OtherDevicesMenu" enum="OtherSessionsActions">
<owner>mad@chromium.org</owner>
<owner>rpop@google.com</owner>
<summary>
@@ -25119,8 +25119,11 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
-<histogram name="NewTabPage.OtherSessionsMenu" enum="NtpOtherSessionsType">
+<histogram name="NewTabPage.OtherSessionsMenu" enum="OtherSessionsActions">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
+ <obsolete>
+ Deprecated 05/2015. Feature was removed.
+ </obsolete>
<summary>
Histogram for usage of the menu on the NTP that allows the user to access
tabs from other devices.
@@ -58988,18 +58991,6 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="13" label="Other action"/>
</enum>
-<enum name="NtpOtherSessionsType" type="int">
- <int value="0" label="Menu initialized"/>
- <int value="1" label="Menu shown"/>
- <int value="2" label="Link clicked"/>
- <int value="3" label="Link context menu shown"/>
- <int value="4" label="Device context menu shown"/>
- <int value="5" label="Unused/previous device context menu shown"/>
- <int value="6" label="Collapse Session"/>
- <int value="7" label="Expand Session"/>
- <int value="8" label="Open All"/>
-</enum>
-
<enum name="NtpPaneType" type="int">
<int value="1" label="MostVisited"/>
<int value="2" label="Apps"/>
@@ -59454,6 +59445,18 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="4" label="Other possible username was selected"/>
</enum>
+<enum name="OtherSessionsActions" type="int">
+ <int value="0" label="Menu initialized"/>
+ <int value="1" label="Menu shown"/>
+ <int value="2" label="Link clicked"/>
+ <int value="3" label="Link context menu shown"/>
+ <int value="4" label="Device context menu shown"/>
+ <int value="5" label="Unused/previous device context menu shown"/>
+ <int value="6" label="Collapse Session"/>
+ <int value="7" label="Expand Session"/>
+ <int value="8" label="Open All"/>
+</enum>
+
<enum name="OverscrollMode" type="int">
<summary>Direction of the overscroll gesture.</summary>
<int value="1" label="North">Scrolled from bottom towards top</int>
« no previous file with comments | « chrome/common/chrome_switches.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698