Chromium Code Reviews

Issue 1140813002: deal more consistently with unsortable edges (Closed)

Created:
5 years, 7 months ago by caryclark
Modified:
5 years, 7 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

deal more consistently with unsortable edges Improve line/curve coincident detection and resolution. This fixed the remaining simple failures. When an edge is unsortable, use the ray intersection to determine the angles' winding. Deal with degenerate segments. TBR=reed@google.com BUG=skia:3588, skia:3762 Committed: https://skia.googlesource.com/skia/+/bca19f77479adfd8ba2171753382bc8bf4c2b4ca

Patch Set 1 #

Patch Set 2 : all tests run without failure in -x mode #

Patch Set 3 : fix linux warning #

Unified diffs Side-by-side diffs Stats (+657 lines, -515 lines)
M src/pathops/SkOpCoincidence.h View 1 chunk +2 lines, -0 lines 0 comments
M src/pathops/SkOpCoincidence.cpp View 1 chunk +32 lines, -0 lines 0 comments
M src/pathops/SkOpSegment.h View 4 chunks +15 lines, -8 lines 0 comments
M src/pathops/SkOpSegment.cpp View 11 chunks +51 lines, -35 lines 0 comments
M src/pathops/SkOpSpan.h View 1 chunk +1 line, -0 lines 0 comments
M src/pathops/SkOpSpan.cpp View 1 chunk +10 lines, -0 lines 0 comments
M src/pathops/SkPathOpsCommon.h View 1 chunk +3 lines, -1 line 0 comments
M src/pathops/SkPathOpsCommon.cpp View 3 chunks +65 lines, -29 lines 0 comments
M src/pathops/SkPathOpsOp.cpp View 2 chunks +22 lines, -36 lines 0 comments
M tests/PathOpsExtendedTest.cpp View 2 chunks +2 lines, -2 lines 0 comments
M tests/PathOpsOpTest.cpp View 13 chunks +16 lines, -15 lines 0 comments
M tests/PathOpsSimplifyTest.cpp View 1 chunk +8 lines, -0 lines 0 comments
M tools/pathops_sorter.htm View 1 chunk +3 lines, -4 lines 0 comments
M tools/pathops_visualizer.htm View 2 chunks +427 lines, -385 lines 0 comments

Messages

Total messages: 7 (3 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140813002/20001
5 years, 7 months ago (2015-05-13 14:46:24 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86_64-Release-Trybot/builds/1036)
5 years, 7 months ago (2015-05-13 14:47:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140813002/40001
5 years, 7 months ago (2015-05-13 15:17:32 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 15:23:54 UTC) #7
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/bca19f77479adfd8ba2171753382bc8bf4c2b4ca

Powered by Google App Engine