Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 1140793002: Enabling asan pnacl toolchain builders. (Closed)

Created:
5 years, 7 months ago by bradn
Modified:
5 years, 7 months ago
Reviewers:
kschimpf, Karl, David Yen
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Enabling asan pnacl toolchain builders. Archiving asan pnacl toolchain builds by revision <BUILDERNAME>/<REV> Archiving asan pancl toolchain trys by the same convention as other tries (<BUILDERNAME>/<BUILDNUMBER>). Reuse the existing package names for asan. BUG=None TEST=None R=dyen@chromium.org, kschimpf@google.com, kschimpf@chromium.org Committed: https://chromium.googlesource.com/native_client/src/native_client/+/a0d24db385c078928be6163e527febebb2e97de1

Patch Set 1 #

Patch Set 2 : fix #

Total comments: 1

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -13 lines) Patch
M buildbot/buildbot_pnacl_toolchain.py View 1 chunk +4 lines, -7 lines 0 comments Download
M buildbot/buildbot_selector.py View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M buildbot/packages.py View 1 1 chunk +10 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
bradn
5 years, 7 months ago (2015-05-12 20:15:58 UTC) #1
Karl
lgtm https://codereview.chromium.org/1140793002/diff/20001/buildbot/buildbot_selector.py File buildbot/buildbot_selector.py (right): https://codereview.chromium.org/1140793002/diff/20001/buildbot/buildbot_selector.py#newcode273 buildbot/buildbot_selector.py:273: # Sanitizer Pnacl toolchain buildbot. Nit: Shouldn't this ...
5 years, 7 months ago (2015-05-12 20:23:30 UTC) #3
David Yen
lgtm
5 years, 7 months ago (2015-05-12 21:12:29 UTC) #4
bradn
Committed patchset #3 (id:40001) manually as a0d24db385c078928be6163e527febebb2e97de1 (presubmit successful).
5 years, 7 months ago (2015-05-12 21:15:37 UTC) #5
Derek Schuff
5 years, 7 months ago (2015-05-12 21:41:27 UTC) #6
Message was sent while issue was closed.
On 2015/05/12 21:15:37, bradn wrote:
> Committed patchset #3 (id:40001) manually as
> a0d24db385c078928be6163e527febebb2e97de1 (presubmit successful).

I'm sorry, my buildbot asplode:
http://build.chromium.org/p/client.nacl.toolchain/builders/linux-pnacl-x86_64...

Powered by Google App Engine
This is Rietveld 408576698