Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3331)

Unified Diff: buildbot/buildbot_pnacl_toolchain.py

Issue 1140793002: Enabling asan pnacl toolchain builders. (Closed) Base URL: https://chromium.googlesource.com/native_client/src/native_client.git@master
Patch Set: fix Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | buildbot/buildbot_selector.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: buildbot/buildbot_pnacl_toolchain.py
diff --git a/buildbot/buildbot_pnacl_toolchain.py b/buildbot/buildbot_pnacl_toolchain.py
index 16ee423bd58dfe76f399f324012f0cbfb34c3bd8..8e7f05a425490d30bd0da4a9063d0f25e04e1961 100755
--- a/buildbot/buildbot_pnacl_toolchain.py
+++ b/buildbot/buildbot_pnacl_toolchain.py
@@ -146,13 +146,10 @@ if args.skip_tests:
sys.exit(0)
if args.buildbot or args.trybot:
- # Don't upload package descriptions when sanitizing, since the
- # package names are the same as for the unsanitized versions.
- if not args.sanitize:
- # Don't upload packages from the 32-bit linux bot to avoid racing on
- # uploading the same packages as the 64-bit linux bot
- if host_os != 'linux' or pynacl.platform.IsArch64Bit():
- packages.UploadPackages(TEMP_PACKAGES_FILE, args.trybot)
+ # Don't upload packages from the 32-bit linux bot to avoid racing on
+ # uploading the same packages as the 64-bit linux bot
+ if host_os != 'linux' or pynacl.platform.IsArch64Bit():
+ packages.UploadPackages(TEMP_PACKAGES_FILE, args.trybot, args.sanitizer)
# Since windows bots don't build target libraries or run tests yet, Run a basic
# sanity check that tests the host components (LLVM, binutils, gold plugin).
« no previous file with comments | « no previous file | buildbot/buildbot_selector.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698