[Extensions] Show enterprise policy icon in the context menu when unremovable

[Extensions] Show enterprise policy icon in the context menu when unremovable

When an extension is force-installed by policy and cannot be removed, show the
enterprise policy icon in the context menu, and change the string from
"Remove frome Chrome..." to be "Installed by your administrator".

BUG=486228
Committed: https://crrev.com/11433b24f1e70c40990c6fba3bff236a71e31fdc
Cr-Commit-Position: refs/heads/master@{#330831}

[Devlin, 2015-05-19 21:02:50]

Patchset #1 (id:1) has been deleted

[Devlin, 2015-05-19 21:02:59]

Patchset #1 (id:20001) has been deleted

[Devlin, 2015-05-19 21:03:21]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Finnur, 2015-05-20 12:02:36]

LGTM, one nit.

https://codereview.chromium.org/1140763003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_context_menu_model.cc (right):

https://codereview.chromium.org/1140763003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_context_menu_model.cc:177:
!policy->MustRemainInstalled(extension, nullptr);
nit: I think I'd like to see a private function capture this condition, since
we're now checking it in two places and those two places should be in sync, I
presume.

[Devlin, 2015-05-20 20:40:18]

https://codereview.chromium.org/1140763003/diff/40001/chrome/browser/extensio...
File chrome/browser/extensions/extension_context_menu_model.cc (right):

https://codereview.chromium.org/1140763003/diff/40001/chrome/browser/extensio...
chrome/browser/extensions/extension_context_menu_model.cc:177:
!policy->MustRemainInstalled(extension, nullptr);
On 2015/05/20 12:02:35, Finnur wrote:
> nit: I think I'd like to see a private function capture this condition, since
> we're now checking it in two places and those two places should be in sync, I
> presume.

Done.

[Devlin, 2015-05-20 20:40:22]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-05-20 20:40:22]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/1140763003/#ps60001
(title: "Finnur's")

[commit-bot: I haz the power, 2015-05-20 20:41:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1140763003/60001

[commit-bot: I haz the power, 2015-05-20 21:26:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-20 21:26:27]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2015-05-20 21:35:46]

Patchset #2 (id:60001) has been deleted

[Devlin, 2015-05-20 21:35:50]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-05-20 21:35:51]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/1140763003/#ps80001
(title: "Finnur's")

[commit-bot: I haz the power, 2015-05-20 21:39:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1140763003/80001

[commit-bot: I haz the power, 2015-05-20 23:13:29]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2015-05-20 23:14:22]

Patchset 2 (id:??) landed as
https://crrev.com/11433b24f1e70c40990c6fba3bff236a71e31fdc
Cr-Commit-Position: refs/heads/master@{#330831}