[Extensions] Show enterprise policy icon in the context menu when unremovable

chrome/browser/extensions/extension_context_menu_model.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_context_menu_model.h"
 
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/app/chrome_command_ids.h"
 #include "chrome/browser/extensions/active_script_controller.h"
@@ skipping 156 matching lines @@
     if (!web_contents)
       return false;
 
     return extension_action_ &&
         extension_action_->HasPopup(SessionTabHelper::IdForTab(web_contents));
   } else if (command_id == UNINSTALL) {
     // Some extension types can not be uninstalled.
     extensions::ManagementPolicy* policy =
         extensions::ExtensionSystem::Get(profile_)->management_policy();
     return policy->UserMayModifySettings(extension, nullptr) &&
            !policy->MustRemainInstalled(extension, nullptr);

[Finnur, 2015/05/20 12:02:35]

nit: I think I'd like to see a private function capture this condition, since
we're now checking it in two places and those two places should be in sync, I
presume.

[Devlin, 2015/05/20 20:40:18]

Done.

   }
   return true;
 }
 
 bool ExtensionContextMenuModel::GetAcceleratorForCommandId(
     int command_id, ui::Accelerator* accelerator) {
   return false;
 }
 
 void ExtensionContextMenuModel::ExecuteCommand(int command_id,
@@ skipping 111 matching lines @@
   WebContents* web_contents = GetActiveWebContents();
   if (web_contents &&
       extensions::ActiveScriptController::GetForWebContents(web_contents)
           ->WantsToRun(extension)) {
     AddItemWithStringId(ALWAYS_RUN, IDS_EXTENSIONS_ALWAYS_RUN);
   }
 
   if (!is_component_ || extensions::OptionsPageInfo::HasOptionsPage(extension))
     AddItemWithStringId(CONFIGURE, IDS_EXTENSIONS_OPTIONS_MENU_ITEM);
 
-  if (!is_component_)
-    AddItem(UNINSTALL, l10n_util::GetStringUTF16(IDS_EXTENSIONS_UNINSTALL));
+  if (!is_component_) {
+    extensions::ManagementPolicy* policy =
+      extensions::ExtensionSystem::Get(profile_)->management_policy();
+    bool is_required_by_policy =
+        !policy->UserMayModifySettings(extension, nullptr) ||
+        policy->MustRemainInstalled(extension, nullptr);
+    int message_id = is_required_by_policy ?
+        IDS_EXTENSIONS_INSTALLED_BY_ADMIN : IDS_EXTENSIONS_UNINSTALL;
+    AddItem(UNINSTALL, l10n_util::GetStringUTF16(message_id));
+    if (is_required_by_policy) {
+      int uninstall_index = GetIndexOfCommandId(UNINSTALL);
+      SetIcon(uninstall_index,
+              ui::ResourceBundle::GetSharedInstance().GetImageNamed(
+                  IDR_CONTROLLED_SETTING_MANDATORY));
+    }
+  }
 
   // Add a toggle visibility (show/hide) if the extension icon is shown on the
   // toolbar.
   int visibility_string_id =
       GetVisibilityStringId(profile_, extension, button_visibility);
   if (visibility_string_id != -1)
     AddItemWithStringId(TOGGLE_VISIBILITY, visibility_string_id);
 
   if (!is_component_) {
     AddSeparator(ui::NORMAL_SEPARATOR);
@@ skipping 20 matching lines @@
   extension_items_count_ = 0;
   extension_items_->AppendExtensionItems(MenuItem::ExtensionKey(extension_id_),
                                          base::string16(),
                                          &extension_items_count_,
                                          true);  // is_action_menu
 }
 
 content::WebContents* ExtensionContextMenuModel::GetActiveWebContents() const {
   return browser_->tab_strip_model()->GetActiveWebContents();
 }