Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1140763002: Extract package_resources step into a .gypi & make assets & resource zips optional (Closed)

Created:
5 years, 7 months ago by agrieve
Modified:
5 years, 7 months ago
Reviewers:
cjhopman, nednguyen
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, sadrul, dtu
Base URL:
https://chromium.googlesource.com/chromium/src.git@apkbuilder
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract package_resources step into a .gypi & make assets & resource zips optional This is in preparation for for creating abi splits BUG=484797 Committed: https://crrev.com/a657e5374014d2125f4fddc319cea852b0c86a96 Cr-Commit-Position: refs/heads/master@{#330188}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -68 lines) Patch
M build/android/gyp/package_resources.py View 2 chunks +10 lines, -9 lines 0 comments Download
A build/android/package_resources_action.gypi View 1 chunk +73 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 2 4 chunks +22 lines, -8 lines 0 comments Download
M build/java_apk.gypi View 1 2 2 chunks +7 lines, -51 lines 0 comments Download
M tools/telemetry/telemetry/TELEMETRY_DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (6 generated)
agrieve
5 years, 7 months ago (2015-05-12 19:38:22 UTC) #1
agrieve
5 years, 7 months ago (2015-05-12 20:10:32 UTC) #3
agrieve
On 2015/05/12 20:10:32, agrieve wrote: Note - can't tryjob yet since patch has https://codereview.chromium.org/1138953003 as ...
5 years, 7 months ago (2015-05-12 20:16:44 UTC) #4
agrieve
nednguyen@google.com: Please review changes in tools/telemetry/telemetry/TELEMETRY_DEPS
5 years, 7 months ago (2015-05-13 13:54:20 UTC) #6
nednguyen
On 2015/05/13 13:54:20, agrieve wrote: > mailto:nednguyen@google.com: Please review changes in > > tools/telemetry/telemetry/TELEMETRY_DEPS lgtm
5 years, 7 months ago (2015-05-13 15:03:42 UTC) #7
nednguyen
5 years, 7 months ago (2015-05-13 15:04:02 UTC) #8
cjhopman
lgtm
5 years, 7 months ago (2015-05-14 00:28:39 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140763002/40001
5 years, 7 months ago (2015-05-14 16:43:21 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/76124) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 7 months ago (2015-05-14 16:52:41 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140763002/40001
5 years, 7 months ago (2015-05-15 19:37:35 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-15 20:39:07 UTC) #17
325583992843-0clp48nf3nc7pk3ll9lp3k65k4ra53j4
Patchset 3 (id:??) landed as https://crrev.com/a657e5374014d2125f4fddc319cea852b0c86a96 Cr-Commit-Position: refs/heads/master@{#330188}
5 years, 7 months ago (2015-05-16 05:38:49 UTC) #18
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:27:06 UTC) #19
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/a657e5374014d2125f4fddc319cea852b0c86a96
Cr-Commit-Position: refs/heads/master@{#330188}

Powered by Google App Engine
This is Rietveld 408576698