Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1138953003: Extract apkbuilder build action into a .gypi (Closed)

Created:
5 years, 7 months ago by agrieve
Modified:
5 years, 7 months ago
Reviewers:
cjhopman, dtu, nednguyen
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@split-manifest
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Extract apkbuilder build action into a .gypi - This is in preparation for split apks, where we'll need to call apkbuilder multiple times. - This also makes including a classes.dex file optional BUG=484797 Committed: https://crrev.com/8dabdfa9a758f7a7ac73fa4f5bbc657183b1a3e2 Cr-Commit-Position: refs/heads/master@{#330159}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : Remove debug statement #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -48 lines) Patch
M build/android/ant/apk-package.xml View 1 chunk +1 line, -1 line 0 comments Download
A build/android/apkbuilder_action.gypi View 1 chunk +79 lines, -0 lines 0 comments Download
M build/config/android/internal_rules.gni View 1 2 3 4 3 chunks +12 lines, -3 lines 0 comments Download
M build/java_apk.gypi View 1 2 3 1 chunk +8 lines, -44 lines 0 comments Download
M tools/telemetry/telemetry/TELEMETRY_DEPS View 1 2 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
agrieve
5 years, 7 months ago (2015-05-12 19:08:02 UTC) #2
agrieve
nednguyen@google.com: Please review changes in tools/telemetry/telemetry/TELEMETRY_DEPS
5 years, 7 months ago (2015-05-13 13:51:52 UTC) #4
nednguyen
Dave: this is because the telemetry bootstrap_deps includes the whole "src/build/android". Can we shrink the ...
5 years, 7 months ago (2015-05-13 15:05:34 UTC) #6
nednguyen
lgtm
5 years, 7 months ago (2015-05-13 16:47:50 UTC) #7
cjhopman
https://codereview.chromium.org/1138953003/diff/40001/build/java_apk.gypi File build/java_apk.gypi (right): https://codereview.chromium.org/1138953003/diff/40001/build/java_apk.gypi#newcode691 build/java_apk.gypi:691: 'inputs': [ '<!(echo "<(_target_name): <(native_lib_target)" >> /tmp/foo.txt)', What's this ...
5 years, 7 months ago (2015-05-14 00:30:42 UTC) #8
agrieve
https://codereview.chromium.org/1138953003/diff/40001/build/java_apk.gypi File build/java_apk.gypi (right): https://codereview.chromium.org/1138953003/diff/40001/build/java_apk.gypi#newcode691 build/java_apk.gypi:691: 'inputs': [ '<!(echo "<(_target_name): <(native_lib_target)" >> /tmp/foo.txt)', On 2015/05/14 ...
5 years, 7 months ago (2015-05-14 13:47:29 UTC) #9
cjhopman
lgtm
5 years, 7 months ago (2015-05-15 18:07:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1138953003/80001
5 years, 7 months ago (2015-05-15 18:22:36 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-15 19:23:39 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 19:24:33 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/8dabdfa9a758f7a7ac73fa4f5bbc657183b1a3e2
Cr-Commit-Position: refs/heads/master@{#330159}

Powered by Google App Engine
This is Rietveld 408576698