Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1140733002: Revert of Revert of Fixes dragging to be less likely to trigger false positive switch to docking (Closed)

Created:
5 years, 7 months ago by varkha
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke, pkotwicz
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Revert of Adjusts dragging logic to be less likely to trigger false positive switch from snapping to docking (patchset #1 id:1 of https://codereview.chromium.org/1128933005/) Reason for revert: This revert probably did not fix the flakiness. I suspect that a revert that actually ended up fixing the bots is this: https://codereview.chromium.org/1139943002. I will re-land my original change. Original issue's description: > Revert of Adjusts dragging logic to be less likely to trigger false positive switch from snapping to docking (patchset #5 id:90001 of https://codereview.chromium.org/1127133003/) > > Reason for revert: > I suspect this is causing a browser_tests failure on the bots: > > http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/2069 > https://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/1913 > > Sorry! > > Original issue's description: > > Adjusts dragging logic to be less likely to trigger false positive switch from > > snapping to docking. > > > > This CL adjusts the logic which selects whether a window will be snapped to > > half of the workspace width or will be docked at the end of the drag when the > > window is dragged to the edge of the workspace in the special case of the dock > > being visible. The CL makes it easier to snap a window to half the workspace > > width in this special case (and harder to inadvertently dock the window) > > > > BUG=484877 > > TEST=None > > > > Committed: https://crrev.com/988c697aff35b3fd347dec35f2f2ac159c8328a9 > > Cr-Commit-Position: refs/heads/master@{#329268} > > TBR=pkotwicz@chromium.org,varkha@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=484877 > > Committed: https://crrev.com/0d4f7d597774f7415f1aff374db498c8fbe88a9a > Cr-Commit-Position: refs/heads/master@{#329301} TBR=pkotwicz@chromium.org,dpranke@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=484877 Committed: https://crrev.com/7c332249b80e021f0c4846c934dfd2f957e489d6 Cr-Commit-Position: refs/heads/master@{#329413}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -26 lines) Patch
M ash/wm/workspace/two_step_edge_cycler.h View 2 chunks +13 lines, -1 line 0 comments Download
M ash/wm/workspace/two_step_edge_cycler.cc View 2 chunks +30 lines, -12 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.h View 1 chunk +5 lines, -10 lines 0 comments Download
M ash/wm/workspace/workspace_window_resizer.cc View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
varkha
Created Revert of Revert of Adjusts dragging logic to be less likely to trigger false ...
5 years, 7 months ago (2015-05-12 16:07:11 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140733002/1
5 years, 7 months ago (2015-05-12 16:10:55 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-12 16:11:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140733002/1
5 years, 7 months ago (2015-05-12 16:13:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 16:14:57 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/7c332249b80e021f0c4846c934dfd2f957e489d6 Cr-Commit-Position: refs/heads/master@{#329413}
5 years, 7 months ago (2015-05-12 16:15:42 UTC) #11
Dirk Pranke
5 years, 7 months ago (2015-05-12 18:42:14 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698