Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: ui/gl/gl_image.h

Issue 1140683002: glBindTexImage2DCHROMIUM should retain pixel format. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gl/gl_image.h
diff --git a/ui/gl/gl_image.h b/ui/gl/gl_image.h
index 214241396becbf60949ed713278eb9ee3323c782..d3e9aa076e8c223c1c9db13aeb5475c28996f98e 100644
--- a/ui/gl/gl_image.h
+++ b/ui/gl/gl_image.h
@@ -27,6 +27,9 @@ class GL_EXPORT GLImage : public base::RefCounted<GLImage> {
// Get the size of the image.
virtual gfx::Size GetSize() = 0;
+ // Get the image pixel format.
reveman 2015/05/12 15:27:19 Internal format is not guaranteed to match the exa
christiank 2015/05/13 09:02:23 Alright, I was debating whether using GetInternalF
+ virtual unsigned GetFormat() = 0;
reveman 2015/05/12 15:27:19 nit: GetInternalFormat() as that's how we refer to
+
// Bind image to texture currently bound to |target|.
virtual bool BindTexImage(unsigned target) = 0;

Powered by Google App Engine
This is Rietveld 408576698