Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1140683002: glBindTexImage2DCHROMIUM should retain pixel format. (Closed)

Created:
5 years, 7 months ago by christiank
Modified:
5 years, 7 months ago
Reviewers:
reveman, jbauman
CC:
chromium-reviews, darin-cc_chromium.org, jam, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

glBindTexImage2DCHROMIUM should retain pixel format. glBindTexImage2DCHROMIUM and glReleaseTexImage2DCHROMIUM will force the texture format in the level info to GL_RGBA regardless of the internal format used by the GLImage. This CL address this by adding a GetFormat function to GLImage that glBindTexImage2DCHROMIUM and glReleaseTexImage2DCHROMIUM will use when updating the level info. BUG= Committed: https://crrev.com/55ddebb83836f9c4ef8b325050db65ead9807299 Cr-Commit-Position: refs/heads/master@{#330336}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Rename to GetInternalFormat and address nits. #

Patch Set 3 : Add GetInternalFormat override to MockGLImage. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -4 lines) Patch
M content/common/gpu/stream_texture_android.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/stream_texture_android.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/stream_texture_manager_in_process_android.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 1 2 chunks +5 lines, -0 lines 0 comments Download
M ui/gl/gl_image.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/gl_image_egl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_image_egl.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_image_glx.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_image_glx.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_image_io_surface.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_image_io_surface.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_image_linux_dma_buffer.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/gl_image_linux_dma_buffer.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_image_memory.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_image_memory.cc View 1 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_image_stub.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_image_stub.cc View 1 2 chunks +4 lines, -0 lines 0 comments Download
M ui/gl/gl_image_surface_texture.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_image_surface_texture.cc View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
christiank
Hi, While working on 1119723003 I noticed that glBindTexImage2DCHROMIUM will always set the texture format ...
5 years, 7 months ago (2015-05-12 07:42:37 UTC) #2
reveman
lgtm with nits Btw, do you mind updating (in a separate patch) the gpu/GLES2/extensions/CHROMIUM/CHROMIUM_image.txt spec ...
5 years, 7 months ago (2015-05-12 15:27:19 UTC) #3
christiank
Sure, I'll update CHROMIUM_image.txt. https://codereview.chromium.org/1140683002/diff/1/ui/gl/gl_image.h File ui/gl/gl_image.h (right): https://codereview.chromium.org/1140683002/diff/1/ui/gl/gl_image.h#newcode30 ui/gl/gl_image.h:30: // Get the image pixel ...
5 years, 7 months ago (2015-05-13 09:02:23 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140683002/20001
5 years, 7 months ago (2015-05-13 09:02:41 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/71516)
5 years, 7 months ago (2015-05-13 09:11:53 UTC) #9
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140683002/40001
5 years, 7 months ago (2015-05-13 09:56:48 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-13 11:12:59 UTC) #14
christiank
jbauman, would you please have a look?
5 years, 7 months ago (2015-05-13 11:20:38 UTC) #15
jbauman
lgtm
5 years, 7 months ago (2015-05-13 21:00:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140683002/40001
5 years, 7 months ago (2015-05-18 07:41:52 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-18 08:56:42 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:34:01 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/55ddebb83836f9c4ef8b325050db65ead9807299
Cr-Commit-Position: refs/heads/master@{#330336}

Powered by Google App Engine
This is Rietveld 408576698