Source/bindings/core/v8/V8LazyEventListener.cpp - Issue 1140613005: v8::Isolate* should be the first parameter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8LazyEventListener.cpp

Issue 1140613005: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/V8LazyEventListener.cpp

diff --git a/Source/bindings/core/v8/V8LazyEventListener.cpp b/Source/bindings/core/v8/V8LazyEventListener.cpp

index 7e8a64366533d9970babfda131a55cc545eb8532..6b36c50e3ca671968cb0c2863f4d937909debb2d 100644

--- a/Source/bindings/core/v8/V8LazyEventListener.cpp

+++ b/Source/bindings/core/v8/V8LazyEventListener.cpp

@@ -51,7 +51,7 @@

namespace blink {

-V8LazyEventListener::V8LazyEventListener(const AtomicString& functionName, const AtomicString& eventParameterName, const String& code, const String sourceURL, const TextPosition& position, Node* node, v8::Isolate* isolate)

+V8LazyEventListener::V8LazyEventListener(v8::Isolate* isolate, const AtomicString& functionName, const AtomicString& eventParameterName, const String& code, const String sourceURL, const TextPosition& position, Node* node)

: V8AbstractEventListener(true, DOMWrapperWorld::mainWorld(), isolate)

, m_functionName(functionName)

, m_eventParameterName(eventParameterName)

« no previous file with comments | « Source/bindings/core/v8/V8LazyEventListener.h ('k') | no next file » | no next file with comments »