Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Side by Side Diff: Source/bindings/core/v8/V8LazyEventListener.cpp

Issue 1140613005: v8::Isolate* should be the first parameter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/core/v8/V8LazyEventListener.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 #include "core/dom/Node.h" 44 #include "core/dom/Node.h"
45 #include "core/frame/LocalFrame.h" 45 #include "core/frame/LocalFrame.h"
46 #include "core/frame/csp/ContentSecurityPolicy.h" 46 #include "core/frame/csp/ContentSecurityPolicy.h"
47 #include "core/html/HTMLElement.h" 47 #include "core/html/HTMLElement.h"
48 #include "core/html/HTMLFormElement.h" 48 #include "core/html/HTMLFormElement.h"
49 49
50 #include "wtf/StdLibExtras.h" 50 #include "wtf/StdLibExtras.h"
51 51
52 namespace blink { 52 namespace blink {
53 53
54 V8LazyEventListener::V8LazyEventListener(const AtomicString& functionName, const AtomicString& eventParameterName, const String& code, const String sourceURL, c onst TextPosition& position, Node* node, v8::Isolate* isolate) 54 V8LazyEventListener::V8LazyEventListener(v8::Isolate* isolate, const AtomicStrin g& functionName, const AtomicString& eventParameterName, const String& code, con st String sourceURL, const TextPosition& position, Node* node)
55 : V8AbstractEventListener(true, DOMWrapperWorld::mainWorld(), isolate) 55 : V8AbstractEventListener(true, DOMWrapperWorld::mainWorld(), isolate)
56 , m_functionName(functionName) 56 , m_functionName(functionName)
57 , m_eventParameterName(eventParameterName) 57 , m_eventParameterName(eventParameterName)
58 , m_code(code) 58 , m_code(code)
59 , m_sourceURL(sourceURL) 59 , m_sourceURL(sourceURL)
60 , m_node(node) 60 , m_node(node)
61 , m_position(position) 61 , m_position(position)
62 { 62 {
63 } 63 }
64 64
(...skipping 158 matching lines...) Expand 10 before | Expand all | Expand 10 after
223 // // Since we only parse once, there's no need to keep data used for parsin g around anymore. 223 // // Since we only parse once, there's no need to keep data used for parsin g around anymore.
224 // m_functionName = String(); 224 // m_functionName = String();
225 // m_code = String(); 225 // m_code = String();
226 // m_eventParameterName = String(); 226 // m_eventParameterName = String();
227 // m_sourceURL = String(); 227 // m_sourceURL = String();
228 228
229 setListenerObject(wrappedFunction); 229 setListenerObject(wrappedFunction);
230 } 230 }
231 231
232 } // namespace blink 232 } // namespace blink
OLDNEW
« no previous file with comments | « Source/bindings/core/v8/V8LazyEventListener.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698