Issue 1140603004: Revert of [DevTools] Fix potential crash in RenderFrameDevToolsAgentHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1140603004: Revert of [DevTools] Fix potential crash in RenderFrameDevToolsAgentHost (Closed)

Created:
5 years, 7 months ago by vkuzkokov

Modified:
5 years, 7 months ago

Reviewers:
dgozman, pfeldman

CC:
chromium-reviews, jam, yurys, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of [DevTools] Fix potential crash in RenderFrameDevToolsAgentHost (patchset #1 id:1 of https://codereview.chromium.org/1132913004/) Reason for revert: See crbug.com/489135 Original issue's description: > [DevTools] Fix potential crash in RenderFrameDevToolsAgentHost > > BUG=483693 > > Committed: https://crrev.com/1771428fefada2d24fab5970b915b941a5014cc1 > Cr-Commit-Position: refs/heads/master@{#330286} TBR=dgozman@chromium.org,pfeldman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=483693 Committed: https://crrev.com/3b641d528bfedb9f15690eb3a102a9ba1830d7a0 Cr-Commit-Position: refs/heads/master@{#330348}

Created: 5 years, 7 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	content/browser/devtools/render_frame_devtools_agent_host.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

vkuzkokov

Created Revert of [DevTools] Fix potential crash in RenderFrameDevToolsAgentHost

5 years, 7 months ago (2015-05-18 11:39:52 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140603004/1

5 years, 7 months ago (2015-05-18 11:40:05 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-18 11:41:18 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/3b641d528bfedb9f15690eb3a102a9ba1830d7a0
Cr-Commit-Position: refs/heads/master@{#330348}