content/browser/devtools/render_frame_devtools_agent_host.cc - Issue 1140603004: Revert of [DevTools] Fix potential crash in RenderFrameDevToolsAgentHost

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/render_frame_devtools_agent_host.cc

Issue 1140603004: Revert of [DevTools] Fix potential crash in RenderFrameDevToolsAgentHost (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/devtools/render_frame_devtools_agent_host.cc

diff --git a/content/browser/devtools/render_frame_devtools_agent_host.cc b/content/browser/devtools/render_frame_devtools_agent_host.cc

index 665885a2f96cd33c78765f585e5dce334148d1d0..6f40d6fae6aa8b86237eeb9a44f1ed6f5efb87f9 100644

--- a/content/browser/devtools/render_frame_devtools_agent_host.cc

+++ b/content/browser/devtools/render_frame_devtools_agent_host.cc

@@ -417,7 +417,6 @@

void RenderFrameDevToolsAgentHost::ClearRenderFrameHost() {

DCHECK(render_frame_host_);

render_frame_host_ = nullptr;

- WebContentsObserver::Observe(nullptr);

dom_handler_->SetRenderFrameHost(nullptr);

if (emulation_handler_)

emulation_handler_->SetRenderFrameHost(nullptr);

« no previous file with comments | « no previous file | no next file » | no next file with comments »