Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1140553002: Make --wait-for-debugger work for mandoline launcher process. (Closed)

Created:
5 years, 7 months ago by jam
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make --wait-for-debugger work for mandoline launcher process. If specified without any switch values, it'll make the launcher process wait. Otherwise one can use an app name of "launcher". Committed: https://crrev.com/a30f77e9853d7583ed53f1048ac178194737bf38 Cr-Commit-Position: refs/heads/master@{#329186}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -25 lines) Patch
M mandoline/app/desktop/main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/runner/android/main.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/runner/child_process.cc View 2 chunks +0 lines, -14 lines 0 comments Download
M mojo/runner/child_process_host.cc View 3 chunks +1 line, -10 lines 0 comments Download
M mojo/runner/init.h View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/runner/init.cc View 1 2 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
jam
5 years, 7 months ago (2015-05-11 17:14:31 UTC) #2
sky
LGTM
5 years, 7 months ago (2015-05-11 17:17:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140553002/1
5 years, 7 months ago (2015-05-11 17:25:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/62648)
5 years, 7 months ago (2015-05-11 17:46:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140553002/20001
5 years, 7 months ago (2015-05-11 18:00:10 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-11 18:11:50 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 18:13:31 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a30f77e9853d7583ed53f1048ac178194737bf38
Cr-Commit-Position: refs/heads/master@{#329186}

Powered by Google App Engine
This is Rietveld 408576698