Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: mojo/runner/child_process_host.cc

Issue 1140553002: Make --wait-for-debugger work for mandoline launcher process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/runner/child_process.cc ('k') | mojo/runner/init.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/runner/child_process_host.cc
diff --git a/mojo/runner/child_process_host.cc b/mojo/runner/child_process_host.cc
index 0a06992cf9004378dec6ca355a8076c0eb5c0bef..316a3a32f4dd85623b893203b6f060377e13286e 100644
--- a/mojo/runner/child_process_host.cc
+++ b/mojo/runner/child_process_host.cc
@@ -13,8 +13,6 @@
#include "base/message_loop/message_loop.h"
#include "base/process/kill.h"
#include "base/process/launch.h"
-#include "base/stl_util.h"
-#include "base/strings/string_split.h"
#include "base/task_runner.h"
#include "base/task_runner_util.h"
#include "mojo/edk/embedder/embedder.h"
@@ -102,6 +100,7 @@ bool ChildProcessHost::DoLaunch() {
switches::kTraceToConsole,
switches::kV,
switches::kVModule,
+ switches::kWaitForDebugger,
};
const base::CommandLine* parent_command_line =
@@ -111,14 +110,6 @@ bool ChildProcessHost::DoLaunch() {
arraysize(kForwardSwitches));
child_command_line.AppendSwitchASCII(switches::kApp, name_);
child_command_line.AppendSwitch(switches::kChildProcess);
- if (parent_command_line->HasSwitch(switches::kWaitForDebugger)) {
- std::vector<std::string> apps_to_debug;
- base::SplitString(
- parent_command_line->GetSwitchValueASCII(switches::kWaitForDebugger),
- ',', &apps_to_debug);
- if (apps_to_debug.empty() || ContainsValue(apps_to_debug, name_))
- child_command_line.AppendSwitch(switches::kWaitForDebugger);
- }
auto args = parent_command_line->GetArgs();
for (const auto& arg : args)
« no previous file with comments | « mojo/runner/child_process.cc ('k') | mojo/runner/init.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698