workers: Change how debugger-tasks are posted to the thread.

Source/core/workers/WorkerThread.cpp

 /*
  * Copyright (C) 2008 Apple Inc. All Rights Reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 231 matching lines @@
             m_isInstrumented = !m_task->taskNameForInstrumentation().isEmpty();
         if (m_isInstrumented)
             InspectorInstrumentation::didPostExecutionContextTask(m_workerThread.workerGlobalScope(), m_task.get());
     }
 
     WorkerThread& m_workerThread;
     OwnPtr<ExecutionContextTask> m_task;
     bool m_isInstrumented;
 };
 
-class RunDebuggerQueueTask final : public ExecutionContextTask {
-public:
-    static PassOwnPtr<RunDebuggerQueueTask> create(WorkerThread* thread)
-    {
-        return adoptPtr(new RunDebuggerQueueTask(thread));
-    }
-    virtual void performTask(ExecutionContext* context) override
-    {
-        ASSERT(context->isWorkerGlobalScope());
-        m_thread->runDebuggerTask(WorkerThread::DontWaitForMessage);
-    }
-
-private:
-    explicit RunDebuggerQueueTask(WorkerThread* thread) : m_thread(thread) { }
-
-    WorkerThread* m_thread;
-};
-
 WorkerThread::WorkerThread(PassRefPtr<WorkerLoaderProxy> workerLoaderProxy, WorkerReportingProxy& workerReportingProxy)
     : m_started(false)
     , m_terminated(false)
     , m_workerLoaderProxy(workerLoaderProxy)
     , m_workerReportingProxy(workerReportingProxy)
     , m_webScheduler(nullptr)
     , m_isolate(nullptr)
     , m_shutdownEvent(adoptPtr(Platform::current()->createWaitableEvent()))
     , m_terminationEvent(adoptPtr(Platform::current()->createWaitableEvent()))
 {
@@ skipping 265 matching lines @@
     m_isolate = nullptr;
 }
 
 void WorkerThread::terminateV8Execution()
 {
     ASSERT(isMainThread());
     m_workerGlobalScope->script()->willScheduleExecutionTermination();
     v8::V8::TerminateExecution(m_isolate);
 }
 
-void WorkerThread::postDebuggerTask(const WebTraceLocation& location, PassOwnPtr<ExecutionContextTask> task)
+void WorkerThread::appendDebuggerTask(PassOwnPtr<WebThread::Task> task)

[kinuko, 2015/05/18 15:19:49]

Assuming that we're also going to remove willEnterNestedLoop etc from this
class, it feels that these two methods (append/run debugger task) and
m_debuggerMessageQueue could be possibly also moved out of this class, so we
could centralize these debugger-specific post tasking logic into one place--
could it be right?

[sadrul, 2015/05/19 03:50:47]

That's an interesting idea. pfeldman@/yurus@: what do you think? Is this
something that could go with https://codereview.chromium.org/1133903005/?

 {
-    m_debuggerMessageQueue.append(WorkerThreadTask::create(*this, task, false));
-    postTask(location, RunDebuggerQueueTask::create(this));
+    m_debuggerMessageQueue.append(task);
 }
 
 MessageQueueWaitResult WorkerThread::runDebuggerTask(WaitMode waitMode)
 {
     ASSERT(isCurrentThread());
     MessageQueueWaitResult result;
     double absoluteTime = MessageQueue<WebThread::Task>::infiniteTime();
     OwnPtr<WebThread::Task> task;
     {
         if (waitMode == DontWaitForMessage)
@@ skipping 21 matching lines @@
     InspectorInstrumentation::didLeaveNestedRunLoop(m_workerGlobalScope.get());
 }
 
 void WorkerThread::setWorkerInspectorController(WorkerInspectorController* workerInspectorController)
 {
     MutexLocker locker(m_workerInspectorControllerMutex);
     m_workerInspectorController = workerInspectorController;
 }
 
 } // namespace blink