Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issue 1140353003: [Telemetry] Disable auto issuing record for thread_times (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
Reviewers:
eakuefner, sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Disable auto issuing record for thread_times BUG=444705 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect Committed: https://crrev.com/2905d303db21f120aab1914f98fe0e44284f82ed Cr-Commit-Position: refs/heads/master@{#330613}

Patch Set 1 : #

Patch Set 2 : Fix tough_compositor_cases #

Patch Set 3 : Fix blink_style & key_idle_power_cases #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -32 lines) Patch
M tools/perf/measurements/blink_style.py View 1 2 2 chunks +11 lines, -9 lines 0 comments Download
M tools/perf/measurements/thread_times.py View 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/measurements/thread_times_unittest.py View 1 chunk +0 lines, -15 lines 0 comments Download
M tools/perf/measurements/timeline_controller.py View 1 4 chunks +12 lines, -5 lines 0 comments Download
M tools/perf/page_sets/key_idle_power_cases.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M tools/perf/page_sets/tough_compositor_cases.py View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
nednguyen
5 years, 7 months ago (2015-05-18 21:55:43 UTC) #3
sullivan
lgtm
5 years, 7 months ago (2015-05-18 22:00:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140353003/20001
5 years, 7 months ago (2015-05-18 22:00:53 UTC) #6
eakuefner
lgtm
5 years, 7 months ago (2015-05-18 22:02:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_perf_bisect on tryserver.chromium.perf (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.perf/builders/mac_perf_bisect/builds/1485)
5 years, 7 months ago (2015-05-18 23:07:13 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140353003/40001
5 years, 7 months ago (2015-05-19 17:09:27 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/66379)
5 years, 7 months ago (2015-05-19 18:41:30 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140353003/60001
5 years, 7 months ago (2015-05-19 19:48:06 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 7 months ago (2015-05-19 21:39:20 UTC) #18
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/2905d303db21f120aab1914f98fe0e44284f82ed Cr-Commit-Position: refs/heads/master@{#330613}
5 years, 7 months ago (2015-05-19 21:40:23 UTC) #19
sullivan
5 years, 7 months ago (2015-05-20 13:41:53 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:60001) has been created in
https://codereview.chromium.org/1151543002/ by sullivan@chromium.org.

The reason for reverting is: Seems to have broken service_worker tests
(http://crbug.com/490130).

Powered by Google App Engine
This is Rietveld 408576698