Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: tools/perf/measurements/blink_style.py

Issue 1140353003: [Telemetry] Disable auto issuing record for thread_times (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix blink_style & key_idle_power_cases Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/perf/measurements/thread_times.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/measurements/blink_style.py
diff --git a/tools/perf/measurements/blink_style.py b/tools/perf/measurements/blink_style.py
index f9ef8759dc1c75127d87fae3075c2e3c7877cf86..b46eab153b22eefb22cca4767c92ec8a170d936f 100644
--- a/tools/perf/measurements/blink_style.py
+++ b/tools/perf/measurements/blink_style.py
@@ -6,6 +6,7 @@ from itertools import starmap
from collections import defaultdict
from telemetry.core import util
from telemetry.core import exceptions
+from telemetry.page import action_runner
from telemetry.page import page_test
from telemetry.value import scalar
@@ -28,15 +29,16 @@ class BlinkStyle(page_test.PageTest):
self._controller.CleanUp(tab)
def ValidateAndMeasurePage(self, page, tab, results):
- tab.ExecuteJavaScript('console.time("wait-for-quiescence");')
- try:
- util.WaitFor(tab.HasReachedQuiescence, 15)
- except exceptions.TimeoutException:
- # Some sites never reach quiesence. As this benchmark normalizes/
- # categories results, it shouldn't be necessary to reach the same
- # state on every run.
- pass
- tab.ExecuteJavaScript('console.timeEnd("wait-for-quiescence");')
+ runner = action_runner.ActionRunner(tab)
+ with runner.CreateInteraction('wait-for-quiescence'):
+ tab.ExecuteJavaScript('console.time("");')
+ try:
+ util.WaitFor(tab.HasReachedQuiescence, 15)
+ except exceptions.TimeoutException:
+ # Some sites never reach quiesence. As this benchmark normalizes/
+ # categories results, it shouldn't be necessary to reach the same
+ # state on every run.
+ pass
tab.ExecuteJavaScript(
'console.time("style-update");'
« no previous file with comments | « no previous file | tools/perf/measurements/thread_times.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698