Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1140273002: Replace GetAllErrorCodesForUma calls with UMA_HISTOGRAM_SPARSE_SLOWLY. (Closed)

Created:
5 years, 7 months ago by davidben
Modified:
5 years, 7 months ago
CC:
chromium-reviews, asanka, cbentzel+watch_chromium.org, benjhayden+dwatch_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fallback-type
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace GetAllErrorCodesForUma calls with UMA_HISTOGRAM_SPARSE_SLOWLY. Per review comment on https://codereview.chromium.org/1127623005/, sparse histograms are preferred. BUG=none Committed: https://crrev.com/ad6fc44cec8b05ff4ef34f9d38e578b08673646e Cr-Commit-Position: refs/heads/master@{#330417}

Patch Set 1 #

Total comments: 6

Patch Set 2 : asvitkine comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -51 lines) Patch
M components/error_page/renderer/net_error_helper_core.cc View 1 2 chunks +6 lines, -10 lines 0 comments Download
M content/browser/download/download_resource_handler.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
M net/base/net_errors.h View 1 chunk +0 lines, -9 lines 0 comments Download
M net/base/net_errors.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M net/dns/host_resolver_impl.cc View 1 3 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
davidben
As promised.
5 years, 7 months ago (2015-05-15 20:36:08 UTC) #2
Alexei Svitkine (slow)
lgtm % comments, thanks for the clean up! https://codereview.chromium.org/1140273002/diff/1/components/error_page/renderer/net_error_helper_core.cc File components/error_page/renderer/net_error_helper_core.cc (right): https://codereview.chromium.org/1140273002/diff/1/components/error_page/renderer/net_error_helper_core.cc#newcode20 components/error_page/renderer/net_error_helper_core.cc:20: #include ...
5 years, 7 months ago (2015-05-15 20:38:28 UTC) #3
davidben
+mmenke for components/error_page/renderer/net_error_helper_core.cc https://codereview.chromium.org/1140273002/diff/1/components/error_page/renderer/net_error_helper_core.cc File components/error_page/renderer/net_error_helper_core.cc (right): https://codereview.chromium.org/1140273002/diff/1/components/error_page/renderer/net_error_helper_core.cc#newcode20 components/error_page/renderer/net_error_helper_core.cc:20: #include "base/metrics/histogram.h" On 2015/05/15 20:38:27, Alexei ...
5 years, 7 months ago (2015-05-15 20:41:01 UTC) #5
mmenke
components/error_page/ LGTM.
5 years, 7 months ago (2015-05-18 14:29:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140273002/20001
5 years, 7 months ago (2015-05-18 17:41:53 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-18 20:59:21 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:43:14 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ad6fc44cec8b05ff4ef34f9d38e578b08673646e
Cr-Commit-Position: refs/heads/master@{#330417}

Powered by Google App Engine
This is Rietveld 408576698