Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1078)

Unified Diff: net/base/net_errors.cc

Issue 1140273002: Replace GetAllErrorCodesForUma calls with UMA_HISTOGRAM_SPARSE_SLOWLY. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@fallback-type
Patch Set: asvitkine comment Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/net_errors.h ('k') | net/dns/host_resolver_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_errors.cc
diff --git a/net/base/net_errors.cc b/net/base/net_errors.cc
index 425cb9195fa2512fec312b0fe9716e093c9f2be4..ddba87b94c59fbbd39e06aae4a2725bca19126e1 100644
--- a/net/base/net_errors.cc
+++ b/net/base/net_errors.cc
@@ -4,22 +4,6 @@
#include "net/base/net_errors.h"
-#include "base/basictypes.h"
-#include "base/metrics/histogram.h"
-#include "base/strings/stringize_macros.h"
-
-namespace {
-
-// Get all valid error codes into an array as positive numbers, for use in the
-// |GetAllErrorCodesForUma| function below.
-#define NET_ERROR(label, value) -(value),
-const int kAllErrorCodes[] = {
-#include "net/base/net_error_list.h"
-};
-#undef NET_ERROR
-
-} // namespace
-
namespace net {
const char kErrorDomain[] = "net";
@@ -68,11 +52,6 @@ bool IsClientCertificateError(int error) {
}
}
-std::vector<int> GetAllErrorCodesForUma() {
- return base::CustomHistogram::ArrayToCustomRanges(
- kAllErrorCodes, arraysize(kAllErrorCodes));
-}
-
Error FileErrorToNetError(base::File::Error file_error) {
switch (file_error) {
case base::File::FILE_OK:
« no previous file with comments | « net/base/net_errors.h ('k') | net/dns/host_resolver_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698