Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 1140223003: [PermissionBubble] identical ctor across platforms. (Closed)

Created:
5 years, 7 months ago by groby-ooo-7-16
Modified:
5 years, 7 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@permbubble
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[PermissionBubble] identical ctor across platforms. Views and Cocoa ctors were taking entirely different parameters - parent window vs Browser*. We need those to be consistent, in preparation for work at managed bubbles. BUG = none Committed: https://crrev.com/4369139d0e771ba2c129e26f1fa04deb4e32118e Cr-Commit-Position: refs/heads/master@{#330730}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Initialize with Initializer. #

Patch Set 3 : Make tests work. #

Patch Set 4 : Allow nil browser for ctor, for unit test use. #

Total comments: 4

Patch Set 5 : Fixed nullptr/NULL/nil issues #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -16 lines) Patch
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm View 1 2 3 4 2 chunks +7 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa_browser_test.mm View 1 2 8 chunks +9 lines, -12 lines 0 comments Download

Messages

Total messages: 18 (5 generated)
groby-ooo-7-16
PTAL
5 years, 7 months ago (2015-05-15 22:43:49 UTC) #2
Robert Sesek
https://codereview.chromium.org/1140223003/diff/1/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm File chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm (right): https://codereview.chromium.org/1140223003/diff/1/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm#newcode18 chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm:18: parent_window_ = browser->window()->GetNativeWindow(); This can remain in the initializer ...
5 years, 7 months ago (2015-05-15 22:44:54 UTC) #3
groby-ooo-7-16
https://codereview.chromium.org/1140223003/diff/1/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm File chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm (right): https://codereview.chromium.org/1140223003/diff/1/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm#newcode18 chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm:18: parent_window_ = browser->window()->GetNativeWindow(); On 2015/05/15 22:44:54, Robert Sesek wrote: ...
5 years, 7 months ago (2015-05-15 23:04:04 UTC) #4
Robert Sesek
lgtm
5 years, 7 months ago (2015-05-15 23:05:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140223003/20001
5 years, 7 months ago (2015-05-15 23:17:00 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/54205) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 7 months ago (2015-05-16 01:03:36 UTC) #9
groby-ooo-7-16
Heads up: Tests fixed, remaining Mac failures seem unrelated. Re-running mac_rel_ng, will land unless it ...
5 years, 7 months ago (2015-05-18 22:47:28 UTC) #10
groby-ooo-7-16
OK, all tests fixed. Need to take var out of member initialization after all. (I ...
5 years, 7 months ago (2015-05-19 22:27:12 UTC) #11
Robert Sesek
https://codereview.chromium.org/1140223003/diff/20002/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm File chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm (right): https://codereview.chromium.org/1140223003/diff/20002/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm#newcode17 chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm:17: : parent_window_(nil), delegate_(NULL), bubbleController_(nil) { nullptr here? https://codereview.chromium.org/1140223003/diff/20002/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm#newcode18 chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm:18: ...
5 years, 7 months ago (2015-05-19 22:28:00 UTC) #12
groby-ooo-7-16
Last heads-up. Most difficult one-liner in a while ;) https://codereview.chromium.org/1140223003/diff/20002/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm File chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm (right): https://codereview.chromium.org/1140223003/diff/20002/chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm#newcode17 chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.mm:17: ...
5 years, 7 months ago (2015-05-20 01:12:47 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140223003/70001
5 years, 7 months ago (2015-05-20 13:47:28 UTC) #16
commit-bot: I haz the power
Committed patchset #5 (id:70001)
5 years, 7 months ago (2015-05-20 13:50:49 UTC) #17
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 13:51:34 UTC) #18
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/4369139d0e771ba2c129e26f1fa04deb4e32118e
Cr-Commit-Position: refs/heads/master@{#330730}

Powered by Google App Engine
This is Rietveld 408576698