chrome/browser/ui/cocoa/browser_window_controller.mm - Issue 1140223003: [PermissionBubble] identical ctor across platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller.mm

Issue 1140223003: [PermissionBubble] identical ctor across platforms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@permbubble

Patch Set: Fixed nullptr/NULL/nil issues Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/browser_window_controller.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_controller.mm b/chrome/browser/ui/cocoa/browser_window_controller.mm

index b33ec488621ba561c59ebb17e5724564451745a7..05f7da8fe435416cf6e32c56951cbcfd0d97c84a 100644

--- a/chrome/browser/ui/cocoa/browser_window_controller.mm

+++ b/chrome/browser/ui/cocoa/browser_window_controller.mm

@@ -1278,7 +1278,8 @@ using content::WebContents;

if (newContents) {

if (!permissionBubbleCocoa_.get()) {

- permissionBubbleCocoa_.reset(new PermissionBubbleCocoa([self window]));

+ DCHECK(browser_.get());

+ permissionBubbleCocoa_.reset(new PermissionBubbleCocoa(browser_.get()));

}

manager = PermissionBubbleManager::FromWebContents(newContents);

if (manager)

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/website_settings/permission_bubble_cocoa.h » ('j') | no next file with comments »