Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 1140183004: Display message when javascript is disabled (Closed)

Created:
5 years, 7 months ago by mdjones
Modified:
5 years, 6 months ago
Reviewers:
nyquist, wychen
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@early-templates
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Display message when javascript is disabled This change adds a message to the distiller results page if the user has javascript disabled. BUG=408231 Committed: https://crrev.com/09692613826b2582d783f59aabb31892efaebc67 Cr-Commit-Position: refs/heads/master@{#331878}

Patch Set 1 #

Patch Set 2 : nit #

Patch Set 3 : Rebase #

Patch Set 4 : iOS grit whitelist #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M build/ios/grit_whitelist.txt View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M components/dom_distiller/core/html/dom_distiller_viewer.html View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M components/dom_distiller/core/viewer.cc View 1 2 1 chunk +10 lines, -4 lines 0 comments Download
M components/dom_distiller_strings.grdp View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
mdjones
5 years, 7 months ago (2015-05-18 16:13:13 UTC) #2
nyquist
lgtm
5 years, 7 months ago (2015-05-19 07:00:28 UTC) #3
wychen
Great job! The user would at least know what went wrong. LGTM.
5 years, 7 months ago (2015-05-19 17:56:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140183004/40001
5 years, 6 months ago (2015-05-28 22:23:59 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/29338)
5 years, 6 months ago (2015-05-28 22:36:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140183004/60001
5 years, 6 months ago (2015-05-28 22:41:50 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-05-28 23:26:56 UTC) #14
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 23:27:58 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/09692613826b2582d783f59aabb31892efaebc67
Cr-Commit-Position: refs/heads/master@{#331878}

Powered by Google App Engine
This is Rietveld 408576698