Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1302)

Unified Diff: components/dom_distiller/core/viewer.cc

Issue 1140183004: Display message when javascript is disabled (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@early-templates
Patch Set: iOS grit whitelist Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/dom_distiller/core/html/dom_distiller_viewer.html ('k') | components/dom_distiller_strings.grdp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/dom_distiller/core/viewer.cc
diff --git a/components/dom_distiller/core/viewer.cc b/components/dom_distiller/core/viewer.cc
index bfb10f03b1f6c452b4d4fd06ab395b4a449083c4..60ea7f10b638fffe20ca58e67928465fff4bfecf 100644
--- a/components/dom_distiller/core/viewer.cc
+++ b/components/dom_distiller/core/viewer.cc
@@ -126,16 +126,22 @@ std::string ReplaceHtmlTemplateValues(
substitutions.push_back(
l10n_util::GetStringUTF8(IDS_DOM_DISTILLER_VIEWER_LOADING_TITLE)); // $1
- substitutions.push_back(css.str()); // $2
+ substitutions.push_back(css.str()); // $2
substitutions.push_back(GetThemeCssClass(theme) + " " +
GetFontCssClass(font_family)); // $3
- substitutions.push_back(original_url); // $4
substitutions.push_back(
- l10n_util::GetStringUTF8(IDS_DOM_DISTILLER_VIEWER_VIEW_ORIGINAL)); // $5
+ l10n_util::GetStringUTF8(IDS_DOM_DISTILLER_VIEWER_NO_DATA_TITLE)); // $4
+ substitutions.push_back(
+ l10n_util::GetStringUTF8(
+ IDS_DOM_DISTILLER_JAVASCRIPT_DISABLED_CONTENT)); // $5
+
+ substitutions.push_back(original_url); // $6
+ substitutions.push_back(
+ l10n_util::GetStringUTF8(IDS_DOM_DISTILLER_VIEWER_VIEW_ORIGINAL)); // $7
- substitutions.push_back(script.str()); // $6
+ substitutions.push_back(script.str()); // $8
return ReplaceStringPlaceholders(html_template, substitutions, NULL);
}
« no previous file with comments | « components/dom_distiller/core/html/dom_distiller_viewer.html ('k') | components/dom_distiller_strings.grdp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698