Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1397)

Unified Diff: net/quic/test_tools/mock_crypto_client_stream_factory.h

Issue 1140173002: Implement per-server ProofVerifyDetails in MockCryptoClientStreamFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment and rename method. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_stream_factory_test.cc ('k') | net/quic/test_tools/mock_crypto_client_stream_factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/test_tools/mock_crypto_client_stream_factory.h
diff --git a/net/quic/test_tools/mock_crypto_client_stream_factory.h b/net/quic/test_tools/mock_crypto_client_stream_factory.h
index b138c70ee87ee992d48b849035cc3217005b8fa7..c96db26ad684ea1abcc59b3afdef780f77088f67 100644
--- a/net/quic/test_tools/mock_crypto_client_stream_factory.h
+++ b/net/quic/test_tools/mock_crypto_client_stream_factory.h
@@ -5,6 +5,7 @@
#ifndef NET_QUIC_TEST_TOOLS_MOCK_CRYPTO_CLIENT_STREAM_FACTORY_H_
#define NET_QUIC_TEST_TOOLS_MOCK_CRYPTO_CLIENT_STREAM_FACTORY_H_
+#include <queue>
#include <string>
#include "net/quic/quic_crypto_client_stream.h"
@@ -18,7 +19,7 @@ class QuicServerId;
class MockCryptoClientStreamFactory : public QuicCryptoClientStreamFactory {
public:
MockCryptoClientStreamFactory();
- ~MockCryptoClientStreamFactory() override {}
+ ~MockCryptoClientStreamFactory() override;
QuicCryptoClientStream* CreateQuicCryptoClientStream(
const QuicServerId& server_id,
@@ -30,9 +31,9 @@ class MockCryptoClientStreamFactory : public QuicCryptoClientStreamFactory {
handshake_mode_ = handshake_mode;
}
- void set_proof_verify_details(
- const ProofVerifyDetails* proof_verify_details) {
- proof_verify_details_ = proof_verify_details;
+ // The caller keeps ownership of |proof_verify_details|.
+ void AddProofVerifyDetails(const ProofVerifyDetails* proof_verify_details) {
+ proof_verify_details_queue_.push(proof_verify_details);
}
MockCryptoClientStream* last_stream() const {
@@ -42,7 +43,7 @@ class MockCryptoClientStreamFactory : public QuicCryptoClientStreamFactory {
private:
MockCryptoClientStream::HandshakeMode handshake_mode_;
MockCryptoClientStream* last_stream_;
- const ProofVerifyDetails* proof_verify_details_;
+ std::queue<const ProofVerifyDetails*> proof_verify_details_queue_;
DISALLOW_COPY_AND_ASSIGN(MockCryptoClientStreamFactory);
};
« no previous file with comments | « net/quic/quic_stream_factory_test.cc ('k') | net/quic/test_tools/mock_crypto_client_stream_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698