Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: net/quic/test_tools/mock_crypto_client_stream_factory.cc

Issue 1140173002: Implement per-server ProofVerifyDetails in MockCryptoClientStreamFactory. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment and rename method. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/test_tools/mock_crypto_client_stream_factory.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/test_tools/mock_crypto_client_stream_factory.cc
diff --git a/net/quic/test_tools/mock_crypto_client_stream_factory.cc b/net/quic/test_tools/mock_crypto_client_stream_factory.cc
index 5088c4347c8ef27cd4d761230c20cca6aa6681b2..ebb561116201b013d908c98f8584a8ad452c2aee 100644
--- a/net/quic/test_tools/mock_crypto_client_stream_factory.cc
+++ b/net/quic/test_tools/mock_crypto_client_stream_factory.cc
@@ -13,10 +13,12 @@ using std::string;
namespace net {
+MockCryptoClientStreamFactory::~MockCryptoClientStreamFactory() {
+}
+
MockCryptoClientStreamFactory::MockCryptoClientStreamFactory()
: handshake_mode_(MockCryptoClientStream::CONFIRM_HANDSHAKE),
- last_stream_(nullptr),
- proof_verify_details_(nullptr) {
+ last_stream_(nullptr) {
}
QuicCryptoClientStream*
@@ -24,9 +26,14 @@ MockCryptoClientStreamFactory::CreateQuicCryptoClientStream(
const QuicServerId& server_id,
QuicClientSession* session,
QuicCryptoClientConfig* crypto_config) {
- last_stream_ = new MockCryptoClientStream(
- server_id, session, nullptr, crypto_config, handshake_mode_,
- proof_verify_details_);
+ const ProofVerifyDetails* proof_verify_details = nullptr;
+ if (!proof_verify_details_queue_.empty()) {
+ proof_verify_details = proof_verify_details_queue_.front();
+ proof_verify_details_queue_.pop();
+ }
+ last_stream_ =
+ new MockCryptoClientStream(server_id, session, nullptr, crypto_config,
+ handshake_mode_, proof_verify_details);
return last_stream_;
}
« no previous file with comments | « net/quic/test_tools/mock_crypto_client_stream_factory.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698