extensions/extensions.gyp - Issue 1140153005: ICU msg format support with more than one arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/extensions.gyp

Issue 1140153005: ICU msg format support with more than one arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/extensions.gyp

diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp

index 7fb6d579df55b52111bfd867edb7e6198d766b90..b052f73437f20f8a865289932a5f4f8353f95f95 100644

--- a/extensions/extensions.gyp

+++ b/extensions/extensions.gyp

@@ -123,6 +123,9 @@

'type': 'static_library',

'dependencies': [

'../base/base.gyp:base',

+ '../base/base.gyp:base_i18n',

+ '../third_party/icu/icu.gyp:icuuc',

+ '../third_party/icu/icu.gyp:icui18n',

jungshik at Google 2015/08/01 14:00:58 Removing two icu lines above still works, but I'm

Ryan Sleevi 2015/08/03 08:01:41 Yeah, since none of the unittests explicitly use I

'../base/base.gyp:base_prefs',

'../components/components.gyp:browsing_data',

'../components/components.gyp:device_event_log_component',

« extensions/browser/BUILD.gn ('K') | « extensions/browser/api/device_permissions_prompt.cc ('k') | extensions/extensions_strings.grd » ('j') | no next file with comments »