extensions/browser/BUILD.gn - Issue 1140153005: ICU msg format support with more than one arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/BUILD.gn

Issue 1140153005: ICU msg format support with more than one arguments (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review comments addressed Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/i18n/message_formatter_unittest.cc ('K') | « chrome/browser/ssl/ssl_error_info.cc ('k') | extensions/browser/api/device_permissions_prompt.cc » ('j') | extensions/extensions.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/BUILD.gn

diff --git a/extensions/browser/BUILD.gn b/extensions/browser/BUILD.gn

index d9c62bbd2e2c6726c0c585425ec07f73bfb6d67b..5116530f43469ff97fd1d7e7c51796b418e469f1 100644

--- a/extensions/browser/BUILD.gn

+++ b/extensions/browser/BUILD.gn

@@ -29,6 +29,7 @@ source_set("browser") {

"//skia",

"//third_party/leveldatabase",

"//third_party/re2",

+ "//third_party/icu",

Ryan Sleevi 2015/07/31 22:19:36 Should this code be explicitly depending on ICU? S

jungshik at Google 2015/08/01 14:00:58 That I wanted to avoid as well, but specifying //b

]

# TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

« base/i18n/message_formatter_unittest.cc ('K') | « chrome/browser/ssl/ssl_error_info.cc ('k') | extensions/browser/api/device_permissions_prompt.cc » ('j') | extensions/extensions.gyp » ('J')