Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1140143002: [Telemetry] Remove results param in shared_state.TearDownState(). (Closed)

Created:
5 years, 7 months ago by nednguyen
Modified:
5 years, 7 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Remove results param in shared_state.TearDownState(). The results param was needed in shared_state.TearDownState() because of page_test.DidRunTest hook. Now that hook is removed, we no longer need to provide access to the results object in this method. BUG=435757 Committed: https://crrev.com/750b6051e37a70291e93522ca111c0e29157e190 Cr-Commit-Position: refs/heads/master@{#329887}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M tools/telemetry/telemetry/internal/story_runner.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/internal/story_runner_unittest.py View 5 chunks +5 lines, -5 lines 0 comments Download
M tools/telemetry/telemetry/page/shared_page_state.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/story/shared_state.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/user_story/android/shared_app_state.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
nednguyen
5 years, 7 months ago (2015-05-14 17:42:07 UTC) #2
sullivan
lgtm
5 years, 7 months ago (2015-05-14 17:44:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140143002/1
5 years, 7 months ago (2015-05-14 17:46:49 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 18:56:46 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 18:57:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/750b6051e37a70291e93522ca111c0e29157e190
Cr-Commit-Position: refs/heads/master@{#329887}

Powered by Google App Engine
This is Rietveld 408576698