Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: tools/telemetry/telemetry/page/shared_page_state.py

Issue 1140143002: [Telemetry] Remove results param in shared_state.TearDownState(). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 import logging 4 import logging
5 import os 5 import os
6 import sys 6 import sys
7 7
8 from telemetry.core import browser_finder 8 from telemetry.core import browser_finder
9 from telemetry.core import browser_finder_exceptions 9 from telemetry.core import browser_finder_exceptions
10 from telemetry.core import browser_info as browser_info_module 10 from telemetry.core import browser_info as browser_info_module
(...skipping 249 matching lines...) Expand 10 before | Expand all | Expand 10 after
260 self._ImplicitPageNavigation() 260 self._ImplicitPageNavigation()
261 self._test.RunPage(self._current_page, self._current_tab, results) 261 self._test.RunPage(self._current_page, self._current_tab, results)
262 except exceptions.Error: 262 except exceptions.Error:
263 if self._test.is_multi_tab_test: 263 if self._test.is_multi_tab_test:
264 # Avoid trying to recover from an unknown multi-tab state. 264 # Avoid trying to recover from an unknown multi-tab state.
265 exception_formatter.PrintFormattedException( 265 exception_formatter.PrintFormattedException(
266 msg='Telemetry Error during multi tab test:') 266 msg='Telemetry Error during multi tab test:')
267 raise page_test.MultiTabTestAppCrashError 267 raise page_test.MultiTabTestAppCrashError
268 raise 268 raise
269 269
270 def TearDownState(self, results): 270 def TearDownState(self):
271 self._StopBrowser() 271 self._StopBrowser()
272 272
273 def _StopBrowser(self): 273 def _StopBrowser(self):
274 if self.browser: 274 if self.browser:
275 self.browser.Close() 275 self.browser.Close()
276 self.browser = None 276 self.browser = None
277 277
278 # Restarting the state will also restart the wpr server. If we're 278 # Restarting the state will also restart the wpr server. If we're
279 # recording, we need to continue adding into the same wpr archive, 279 # recording, we need to continue adding into the same wpr archive,
280 # not overwrite it. 280 # not overwrite it.
(...skipping 25 matching lines...) Expand all
306 class SharedDesktopPageState(SharedPageState): 306 class SharedDesktopPageState(SharedPageState):
307 _device_type = 'desktop' 307 _device_type = 'desktop'
308 308
309 309
310 class SharedTabletPageState(SharedPageState): 310 class SharedTabletPageState(SharedPageState):
311 _device_type = 'tablet' 311 _device_type = 'tablet'
312 312
313 313
314 class Shared10InchTabletPageState(SharedPageState): 314 class Shared10InchTabletPageState(SharedPageState):
315 _device_type = 'tablet_10_inch' 315 _device_type = 'tablet_10_inch'
OLDNEW
« no previous file with comments | « tools/telemetry/telemetry/internal/story_runner_unittest.py ('k') | tools/telemetry/telemetry/story/shared_state.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698