Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 1140093003: Merge to XFA: Fix comparison of CFX_ByteString and CFX_WideString. (Closed)

Created:
5 years, 7 months ago by Tom Sepez
Modified:
5 years, 7 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Fix comparison of CFX_ByteString and CFX_WideString. Original Review URL: https://codereview.chromium.org/1141763002 BUG=pdfium:160 TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/e83c77e9a68f2e0ac7632ac40f5b09a0e888093a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+428 lines, -225 lines) Patch
M core/src/fxcrt/fx_basic_bstring.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxcrt/fx_basic_bstring_unittest.cpp View 2 chunks +210 lines, -108 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M core/src/fxcrt/fx_basic_wstring_unittest.cpp View 2 chunks +210 lines, -109 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Tom Sepez
TBR'd.
5 years, 7 months ago (2015-05-13 21:24:24 UTC) #1
Tom Sepez
Committed patchset #1 (id:1) manually as e83c77e9a68f2e0ac7632ac40f5b09a0e888093a (presubmit successful).
5 years, 7 months ago (2015-05-13 21:27:17 UTC) #2
Lei Zhang
5 years, 7 months ago (2015-05-13 21:31:53 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698