Issue 1141763002: Fix comparison of CFX_ByteString and CFX_WideString against empty literals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1141763002: Fix comparison of CFX_ByteString and CFX_WideString against empty literals. (Closed)

Created:
5 years, 7 months ago by Tom Sepez

Modified:
5 years, 7 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix comparison of CFX_ByteString and CFX_WideString against empty literals. Also corrects some ASSERT_'s to EXPECT_'s in the test. BUG=pdfium:160 R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/fdc5e691745cf16fb105f3ad4a9fb5f8f64f56b4

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+428 lines, -225 lines)			Patch
M	core/src/fxcrt/fx_basic_bstring.cpp	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	core/src/fxcrt/fx_basic_bstring_unittest.cpp	View	1 2	2 chunks	+210 lines, -108 lines	0 comments	Download
M	core/src/fxcrt/fx_basic_wstring.cpp	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	core/src/fxcrt/fx_basic_wstring_unittest.cpp	View	1 2	2 chunks	+210 lines, -109 lines	0 comments	Download

Total messages: 6 (1 generated)

Tom Sepez

Turns out there's another case to cover, see new tests.

5 years, 7 months ago (2015-05-13 20:58:07 UTC) #4

Tom Sepez

5 years, 7 months ago (2015-05-13 21:16:56 UTC) #6

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
fdc5e691745cf16fb105f3ad4a9fb5f8f64f56b4 (presubmit successful).