Code Refactor and making function static in frame_navigation_state.

Code Refactor in web_navigation and making IsValidUrl() function static in frame_navigation_state.

BUG=487618
Committed: https://crrev.com/d38b93f73108ca0a8cae75de1731f6c76347b6ab
Cr-Commit-Position: refs/heads/master@{#330092}

[Deepak, 2015-05-14 07:13:08]

deepak.m1@samsung.com changed reviewers:
+ nasko@chromium.org

[Deepak, 2015-05-14 07:13:09]

Please review.
Thanks

[nasko, 2015-05-14 17:00:41]

The move to static method looks good, but I have question on the reason behind
the rest of the refactor.

https://codereview.chromium.org/1140023002/diff/160001/chrome/browser/extensi...
File chrome/browser/extensions/api/web_navigation/frame_navigation_state.h
(right):

https://codereview.chromium.org/1140023002/diff/160001/chrome/browser/extensi...
chrome/browser/extensions/api/web_navigation/frame_navigation_state.h:39: static
bool IsValidUrl(const GURL& url);
static methods should be declared at the beginning of the section. Once you move
it up, please ensure the same ordering is applied to the .cc file.

https://codereview.chromium.org/1140023002/diff/160001/chrome/browser/extensi...
File chrome/browser/extensions/api/web_navigation/web_navigation_api.cc (right):

https://codereview.chromium.org/1140023002/diff/160001/chrome/browser/extensi...
chrome/browser/extensions/api/web_navigation/web_navigation_api.cc:474: void
WebNavigationTabObserver::DispatchErrorToHelper(
First of all, it is unrelated to the change you are making - making a method
static. Second, there is no benefit from moving one function call into another
function call that makes that same function call. Why is this method introduced?

[Deepak, 2015-05-15 03:53:11]

Thanks for review.
Changes done as suggested.
PTAL

[nasko, 2015-05-15 13:17:36]

LGTM

[Deepak, 2015-05-15 13:18:17]

On 2015/05/15 13:17:36, nasko wrote:
> LGTM

Thanks.

[Deepak, 2015-05-15 13:18:22]

The CQ bit was checked by deepak.m1@samsung.com

[commit-bot: I haz the power, 2015-05-15 13:18:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1140023002/180001

[commit-bot: I haz the power, 2015-05-15 14:19:38]

Committed patchset #10 (id:180001)

[commit-bot: I haz the power, 2015-05-15 14:20:43]

Patchset 10 (id:??) landed as
https://crrev.com/d38b93f73108ca0a8cae75de1731f6c76347b6ab
Cr-Commit-Position: refs/heads/master@{#330092}