Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 1140013004: Revert of Disable user gesture checking for all autofill browser tests. (Closed)

Created:
5 years, 7 months ago by aurimas (slooooooooow)
Modified:
5 years, 7 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, glider+watch_chromium.org, rouslan+autofillwatch_chromium.org, bruening+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable user gesture checking for all autofill browser tests. (patchset #2 id:20001 of https://codereview.chromium.org/1125173006/) Reason for revert: This CL broke Linux GN Clobber bot. Original issue's description: > Disable user gesture checking for all autofill browser tests. > > When drmemory_full runs, the browser tests are slowed down enough to > timeout the user gesture indicator, which prevents autofill from > processing the input and passing the browser test. The fix is to disable > user gesture checking for all autofill browser tests except > AutofillRendererTest.IgnoreNonUserGestureTextFieldChanges. > > BUG=484910 TBR=estade@chromium.org,thestig@chromium.org,rouslan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=484910 Committed: https://crrev.com/34e43ad7fc1cc245cd281dd56a9962f169a62307 Cr-Commit-Position: refs/heads/master@{#330272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -58 lines) Patch
M chrome/renderer/autofill/autofill_renderer_browsertest.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 5 chunks +5 lines, -44 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 2 chunks +1 line, -5 lines 0 comments Download
M tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory.txt View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
aurimas (slooooooooow)
Created Revert of Disable user gesture checking for all autofill browser tests.
5 years, 7 months ago (2015-05-16 03:02:46 UTC) #1
aurimas (slooooooooow)
On 2015/05/16 at 03:02:46, aurimas wrote: > Created Revert of Disable user gesture checking for ...
5 years, 7 months ago (2015-05-16 03:03:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1140013004/1
5 years, 7 months ago (2015-05-16 03:03:47 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-16 03:05:15 UTC) #4
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:31:08 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/34e43ad7fc1cc245cd281dd56a9962f169a62307
Cr-Commit-Position: refs/heads/master@{#330272}

Powered by Google App Engine
This is Rietveld 408576698