components/autofill/content/renderer/autofill_agent.cc - Issue 1140013004: Revert of Disable user gesture checking for all autofill browser tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/renderer/autofill_agent.cc

Issue 1140013004: Revert of Disable user gesture checking for all autofill browser tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/renderer/autofill_agent.h ('k') | tools/valgrind/gtest_exclude/browser_tests.gtest-drmemory.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/renderer/autofill_agent.cc

diff --git a/components/autofill/content/renderer/autofill_agent.cc b/components/autofill/content/renderer/autofill_agent.cc

index bf1f54a3a13beb0f25d6dcec881e19512ad53dcb..b994e4d4efbdc306de76a6a47f92a40686c33697 100644

--- a/components/autofill/content/renderer/autofill_agent.cc

+++ b/components/autofill/content/renderer/autofill_agent.cc

@@ -388,7 +388,7 @@

if (ignore_text_changes_)

return;

- if (!IsUserGesture())

+ if (!WebUserGestureIndicator::isProcessingUserGesture())

return;

// We post a task for doing the Autofill as the caret position is not set

@@ -750,10 +750,6 @@

return;

is_popup_possibly_visible_ = false;

Send(new AutofillHostMsg_HidePopup(routing_id()));

-bool AutofillAgent::IsUserGesture() const {

- return WebUserGestureIndicator::isProcessingUserGesture();

}

void AutofillAgent::didAssociateFormControls(const WebVector<WebNode>& nodes) {