Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 1139923005: Clarify the documentation for url::{AddStandardScheme,IsStandard}. (Closed)

Created:
5 years, 7 months ago by palmer
Modified:
5 years, 7 months ago
Reviewers:
brettw, abarth-chromium
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clarify the documentation for url::{AddStandardScheme,IsStandard}. And GURL::IsStandard, which calls url::IsStandard. BUG=487399 TBR=abarth Committed: https://crrev.com/29ae548c923ccd5f4c61ab1609006bed1a34ee4f Cr-Commit-Position: refs/heads/master@{#330495}

Patch Set 1 #

Patch Set 2 : Tighten the definition by referring to RFC 3986. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -25 lines) Patch
M url/gurl.h View 1 1 chunk +5 lines, -4 lines 0 comments Download
M url/url_util.h View 1 3 chunks +15 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
brettw
LGTM
5 years, 7 months ago (2015-05-16 00:12:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139923005/20001
5 years, 7 months ago (2015-05-19 02:41:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-19 08:43:45 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 08:44:43 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/29ae548c923ccd5f4c61ab1609006bed1a34ee4f
Cr-Commit-Position: refs/heads/master@{#330495}

Powered by Google App Engine
This is Rietveld 408576698