Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: url/gurl.h

Issue 1139923005: Clarify the documentation for url::{AddStandardScheme,IsStandard}. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tighten the definition by referring to RFC 3986. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | url/url_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: url/gurl.h
diff --git a/url/gurl.h b/url/gurl.h
index b9136b81f6a8b962a79d3e0435addc614a1e6bb0..c0ad418add981f2e56644f35dcb14dde757aaf77 100644
--- a/url/gurl.h
+++ b/url/gurl.h
@@ -194,10 +194,11 @@ class URL_EXPORT GURL {
// returned.
GURL GetAsReferrer() const;
- // Returns true if the scheme for the current URL is a known "standard"
- // scheme. Standard schemes have an authority and a path section. This
- // includes file: and filesystem:, which some callers may want to filter out
- // explicitly by calling SchemeIsFile[System].
+ // Returns true if the scheme for the current URL is a known "standard-format"
+ // scheme. A standard-format scheme adheres to what RFC 3986 calls "generic
+ // URI syntax" (https://tools.ietf.org/html/rfc3986#section-3). This includes
+ // file: and filesystem:, which some callers may want to filter out explicitly
+ // by calling SchemeIsFile[System].
bool IsStandard() const;
// Returns true if the given parameter (should be lower-case ASCII to match
« no previous file with comments | « no previous file | url/url_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698