Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 1139883007: Sync: ParentChildIndex fix for out of order deletion of entries by PurgeEntriesWithTypeIn. (Closed)

Created:
5 years, 7 months ago by stanisc
Modified:
5 years, 7 months ago
Reviewers:
pavely
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync: ParentChildIndex fix for out of order deletion of entries by PurgeEntriesWithTypeIn. This is an incremental fix for 438313 that addresses the two issues mentioned here: https://code.google.com/p/chromium/issues/detail?id=438313#c24 This issues are reproducible only with the alpha server with implicit permanent folders enabled. I added a test case for one of them - the out of order deletion which results in deleting the permanent folder for a datatype before some of the items of the same datatype. That occurs only in one particular corner case when a failed datatype need to be purged and re-downloaded. BUG=438313 Committed: https://crrev.com/0ddf23080ef7d1317485e76d77a69e857b697580 Cr-Commit-Position: refs/heads/master@{#330657}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -13 lines) Patch
M chrome/browser/sync/glue/typed_url_change_processor.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M sync/syncable/parent_child_index.cc View 2 chunks +1 line, -10 lines 0 comments Download
M sync/syncable/parent_child_index_unittest.cc View 1 chunk +37 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
stanisc
PTAL
5 years, 7 months ago (2015-05-19 18:42:47 UTC) #3
pavely
lgtm
5 years, 7 months ago (2015-05-19 21:28:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1139883007/20001
5 years, 7 months ago (2015-05-20 00:21:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 7 months ago (2015-05-20 00:29:11 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 00:30:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0ddf23080ef7d1317485e76d77a69e857b697580
Cr-Commit-Position: refs/heads/master@{#330657}

Powered by Google App Engine
This is Rietveld 408576698